Use an Arm compatible base image for docker-native on arm #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For both Arm and X86 we are using an alpine base image. There is no Arm variant of Alpine, so this builds an ARM native binary, then puts it in an x86 base image. This change switches to use cgr.dev/chainguard/wolfi-base:latest when the architecture is Arm. This image was chosen due to it's size... There may be a better default choice out there...
alvarosanchez
approved these changes
Sep 15, 2023
...maven-integration-tests/src/it/dockerfile-docker-native-netty-custom-base/invoker.properties
Outdated
Show resolved
Hide resolved
micronaut-maven-integration-tests/src/it/dockerfile-docker-native-netty-custom-base/pom.xml
Outdated
Show resolved
Hide resolved
...n-tests/src/it/dockerfile-docker-native-netty-custom-base/src/main/resources/application.yml
Outdated
Show resolved
Hide resolved
alvarosanchez
requested changes
Sep 15, 2023
Co-authored-by: Álvaro Sánchez-Mariscal <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For both Arm and X86 we are using an alpine base image.
There is no Arm variant of Alpine, so this builds an ARM native binary, then puts it in an x86 base image.
This change switches to use cgr.dev/chainguard/wolfi-base:latest when the architecture is Arm.
This image was chosen due to it's size... There may be a better default choice out there...
This is the Maven version of micronaut-projects/micronaut-gradle-plugin#830