Draft of BucketOperations #361
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With local and oci implementation. Local only lists configured buckets, not much else that makes sense. OCI needs a namespace configuration unfortunately. It's also not clear what the prefix should be, micronaut.object-storage.oracle-cloud.* is already used so i used micronaut.object-storage.oracle-cloud-dynamic but that doesn't really make obvious what this is for. I think other cloud providers should be easier to implement, with a single BucketOperations impl only.
|
SonarCloud Quality Gate failed.
|
|
@alvarosanchez this passes now. but the azure changes kind of suck, so i'll leave this with you for now. |
|
@yawkat I'm fine thanks, this will wait for you once you're available again 😉 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With local and oci implementation.
Local only lists configured buckets, not much else that makes sense.
OCI needs a namespace configuration unfortunately. It's also not clear what the prefix should be, micronaut.object-storage.oracle-cloud.* is already used so i used micronaut.object-storage.oracle-cloud-dynamic but that doesn't really make obvious what this is for.
I think other cloud providers should be easier to implement, with a single BucketOperations impl only.
WDYT @alvarosanchez