-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the namespace validation for oracle metrics #471
base: 3.8.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some tests for the regex, please?
3662100
to
f785a24
Compare
For some reason a namespace with a dash, like This is weird as namespace matching I changed the pattern to |
...c/test/groovy/io/micronaut/oraclecloud/monitoring/OracleCloudMeterRegistryFactorySpec.groovy
Show resolved
Hide resolved
Absolutely. Please go ahead |
f785a24
to
ba1ff9c
Compare
ba1ff9c
to
cf0a9f9
Compare
Seems like everything was correct in the first place. The oci sdk docs show an incorrect example of namespace, though. |
One test failed, can you please have a look? Also, could you please create a remote branch in this repo instead of working on a fork? If you fork, there are some GitHub actions that will fail because the secrets are not exposed to forks. |
@andriy-dmytruk is this still needed? |
Add validation that namespace doesn't start with
oci_