Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make JwtTokenValidator not a bean #1848

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

kevin-wise
Copy link
Contributor

  • remove @Inject so JwtTokenValidator will no longer be a bean candidate
  • allow disabling NimbusReactiveJsonWebTokenValidator in case of custom implementation

fixes #1845

- remove `@Inject` so JwtTokenValidator will no longer be a bean candidate
- allow disabling NimbusReactiveJsonWebTokenValidator in case of custom implementation
@kevin-wise
Copy link
Contributor Author

@sdelamo this is coming from the discussion in micronaut-projects/micronaut-core#10924

@sdelamo sdelamo added the type: bug Something isn't working label Nov 13, 2024
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I have change the configuration properties to be micronaut.security.token.jwt.nimbus.validator and micronaut.security.token.jwt.nimbus.reactive-validator

@sdelamo sdelamo merged commit 99d6002 into micronaut-projects:4.11.x Nov 13, 2024
13 checks passed
@kevin-wise kevin-wise deleted the fix/issue-1845 branch November 13, 2024 19:01
@kevin-wise
Copy link
Contributor Author

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Both JwtTokenValidator and NimbusReactiveJsonWebTokenValidator are active and called
2 participants