For Maven, if a dependency with runtime and test, a compile dependency is added

[sdelamo]

if a dependency is added to the scopes runtime and test in maven. The dependency should be in compile only for maven.

We should not generate this:

<dependency>
  <groupId>ch.qos.logback</groupId>
  <artifactId>logback-classic</artifactId>
  <scope>runtime</scope>
</dependency>
<dependency>
  <groupId>ch.qos.logback</groupId>
  <artifactId>logback-classic</artifactId>
  <scope>test</scope>
</dependency>

But this:

<dependency>
  <groupId>ch.qos.logback</groupId>
  <artifactId>logback-classic</artifactId>
  <scope>compile</scope>
</dependency>

[melix]

I don't understand this fix. A compile dependency will make the dependency part of the transitive compile dependencies, which will leak to consumers. Having both runtime and test dependencies is more accurate, since these are really runtime only deps.

[alvarosanchez]

Agree with @melix. Moreover, the extra test scope is redundant since runtime dependencies are already in the test classpath

[sdelamo]

In maven, what we are seeing is that if you have:

<dependency>
  <groupId>ch.qos.logback</groupId>
  <artifactId>logback-classic</artifactId>
  <scope>runtime</scope>
</dependency>
<dependency>
  <groupId>ch.qos.logback</groupId>
  <artifactId>logback-classic</artifactId>
  <scope>test</scope>
</dependency>

then there is no logback at runtime. it seems the dependency is set as test scope only.
You can see it in action in this guide: https://guides.micronaut.io/latest/micronaut-server-filter-request-maven-java.html

[alvarosanchez]

Probably the latter overrides the former. The extra test scope needs to be removed

[sdelamo]

@alvarosanchez and @melix

I have changed the PR.

For Maven

These dependencies:

<dependency>
  <groupId>ch.qos.logback</groupId>
  <artifactId>logback-classic</artifactId>
  <scope>runtime</scope>
</dependency>
<dependency>
  <groupId>ch.qos.logback</groupId>
  <artifactId>logback-classic</artifactId>
  <scope>test</scope>
</dependency>

get converted to:

<dependency>
  <groupId>ch.qos.logback</groupId>
  <artifactId>logback-classic</artifactId>
  <scope>runtime</scope>
</dependency>

For Gradle

These dependencies:

runtimeOnly("ch.qos.logback:logback-classic")
testImplementation("ch.qos.logback:logback-classic")

it remains the same:

runtimeOnly("ch.qos.logback:logback-classic")
testImplementation("ch.qos.logback:logback-classic")