-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Microprofile BOM/POM #35
Comments
@keilw Just merged #40 (per your comment in #38). But, also be aware that it might be difficult to line up the vendor support of MP 1.1... I still think it would be worthwhile to use the MicroProfile 1.0 bom instead of the java ee 7 bom though... Even though we are crossing the border from Eclipse to the microprofile.io deliverable... |
There is no release tag, so it could be done in 2 stages. First use the 1.0 BOM from MavenCentral, then likely with extra repo entries pointing to Eclipse.org offer a 1.1 one? WDYT? |
Yes, agree. Thanks. |
@kwsutter Please find my new PR for 1.0. I also used the sample for a very brief local demo of https://github.com/eclipse/microprofile-health at DWX tomorrow with @ivargrimstad. I won't propose a PR yet as even Snapshot repo has no Health artifacts, but maybe for a future release that can go into one of the sample projects. |
I created/modified #43 to apply MicroProfile 1.2. I thought about doing a 1.1 compliant sample but there have been no samples that make use of MP Config 1.0 so far (which is the only ingredient of 1.1) so unless somebody wants to still do this for 1.1, I'm just about to upgrade my DWX improvements to HealthCheck 1.0 and update/create a new PR for that. If we do a samples 1.0 build or bump it straight to 1.2, please advise, 1.2 could be easier to match the corresponding MP version ;-) |
Once an official MP BOM (holding together the 1.0 ingredients) is released to a public place, samples should reference it.
The text was updated successfully, but these errors were encountered: