-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Microprofile BOM/POM #41
Conversation
Task-Url: https://github.com/microprofile/microprofile-samples/issues/issues/35 Signed-off-by: Werner Keil <[email protected]>
Task-Url: https://github.com/microprofile/microprofile-samples/issues/issues/35 Signed-off-by: Werner Keil <[email protected]>
@kwsutter Was there an issue with this preventing to merge it? |
@jclingan @kwsutter What exactly is blocking the use of an already published BOM? |
With MicroProfle 1.2 out now, is it possible to use the dependency as written in the main pdf on http://microprofile.io/:
|
Could do, but it is extremely sad having missed a proper release cycle under https://github.com/eclipse/microprofile-samples/releases for 1.1. Do you want to skip it and go right to 1.2 or do 1.1 properly first and then upgrade these samples? |
/** | ||
* @author Werner Keil | ||
*/ | ||
public class CanonicalHealthCheckResponseProvider implements HealthCheckResponseProvider{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the app does not implement the spi but use application server's implementation, e.g. Open Liberty etc. Application should only provide the HealthCheckResponse. One of the benefits of MP programming model is to make app development a lot easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
||
@Path("/health") | ||
@RequestScoped | ||
public class HealthEndpoint { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you want this either according to what @Emily-Jiang wrote, but rather just provide an @Health
method as e.g. shown in https://github.com/pilhuhn/microprofile-demo/blob/master/src/main/java/de/bsd/microprofiledemo/rest/HealthDemo.java#L29-L37
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above example looks vendor-neutral as opposed to what @Emily-Jiang suggested sounded a bit more like abandoning a vendor-neutral Eclipse example altogether in favor of examples by OpenLiberty, Wildfly, Kumuluz, etc. ?;-O
I'm closing this now, MP 1.3 has already been out. I think it would be about time, the samples match some release, otherwise they become outdated and useless. |
See #35
This applied the 1.0.0 BOM