Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Telemetry TCK into a single archive #257

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jasondlee
Copy link
Contributor

Move sources and resources
Update POM file
Modify artifactID to match
Merge READMEs

Resolves #244

Move sources and resources
Update POM file
Modify artifactID to match
@brunobat
Copy link
Contributor

brunobat commented Feb 11, 2025

This PR reduces the wiring triplication on the TCK.
We can run independent tests for tracing, metrics and logging by tweaking the test config file. A point in favor of keeping things separated but that can nevertheless be achieved with this PR.

@jasondlee
Copy link
Contributor Author

Right. This doesn't prevent someone from running tests for just one signal type (I'm not sure why one would, as that's not how TCKs work, think :) , but it does make it easier to set up the environment to run the suite in general.

@Emily-Jiang
Copy link
Member

I think having separate archives allows the runtime to just focus on one set of tcks if they only support subset of this spec. Besides, the three pillars have different progress on making changes etc.

@jasondlee
Copy link
Contributor Author

My guess is that the general case is that someone is implementing "the spec" and we should optimize for that. Someone can still test only one pillar if so desired. The process would be same (configure with a single jar), but the tests would be restricted to a given package. Playing the "what if" game too much (e.g., "what if someone only wants to support JVM metrics and not application?") can lead (as is the case here, I think) of optimizing for random, probably rare (ish) scenarios, which increases complexity for more common cases with little added value.

I'm not sure the pace of development per pillar is relevant here, as the MP Telemetry spec pins otel to a given version, and the TCK covering all three pillars (whether in 1 jar or 3) is released with a single version (that of the spec) covering that version of otel. We are not producing pillar-specific TCK artifacts with varying versions, so this seems moot.

@Emily-Jiang
Copy link
Member

I don't feel there is a business need for merging the archives. I prefer to keep as it is for now unless there are business reasons arsing for the merge.

@jasondlee
Copy link
Contributor Author

I don't see a business NOT to merge it, as it both maintains current flexibility while lowering the barrier to entry by reducing complexity. The only "valid" argument I can see is maintaining the status quo, but I find that pretty uncompelling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine TCKs into a single archive
3 participants