972: Refiner Grouping

[edarroudi]

See #972
This is just a draft for now as there might be the need for additional options, security checks ...

Todos:

1. Additional language resources
2. Check for possible security issues
3. Update documentation
4. Many tests / combinations
5. How to go on with the counts. Its probably impossible to correctly calculate the "advanced" mode count

Decided to check the following 2 options in another version. Will add too much complexity right now.
[optional] Allow the usage of Tokens in the advanced (and simple) fql.
[optional] Allow user to set if Grouped labels should stay of the top of the Combobox/Checkbox

Regarding the advanced FQL request: It works but i'm not sure if it is really correct from the syntax :)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[wobba]

Sorry we don't have time to properly test this for the next release, but will get it included in the v4.8 release.

[wobba]

Should we set this from draft and start to address it?

[edarroudi]

Should we set this from draft and start to address it?

no I still have to adress some issues / optimize it. I'm thinking of switching to a rule tree control for the advanced KQL mode but I have to finish that controll here pnp/sp-dev-fx-property-controls#456 (very soon).

Will concentrate on this PR beginning next week. Do you know when you guys will publish 4.8.0 ?

[edarroudi]

@wobba I had some time to think about it. The advanced Editor is not necessary and as it would lead to a lot of work I think we should move forward with this solution. My questions / Todos are still open - I will continue / finish the implementation once you and @FranckyC come to a conclusion or have some remarks on this - otherwise I will be investing a lot of time without knowing if you guys are actually ok with the approach. Thats why I set this now to Ready for reveiew - although it's not really 100% ready ;-)

[edarroudi]

Update 2022-11-11
I'm currently updating the handling of Grouped Filter (Labels) and testing everything. Will request a review once done (probably by monday).

[edarroudi]

I fixed some issues and tested it many times. From my perspektive it works fine.
I don't allow refiner grouping on date type templates yet. Maybe in a future version? Don't know if i would have to check several issues there.

@FranckyC do you have some time to check / comment this?

Once I get a go I update the rest of the language files and the docs. Thank you.

[edarroudi]

I will add and test number fields with ranges next week. And check what has to be done for date fields

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
5.0% Duplication

[edarroudi]

For now again in draft, will recheck this. Maybe wil start with some refactoring of the base filter code itself in another branch.

[wobba]

Should we close this one?

[edarroudi]

Yeah there is too much work left for it to work in every scenario. And those users who want to have grouped refiners can implement it through UI in the current version.

[mozilla0]

@edarroudi where did you implement this in the UI?

[MirasMNC]

Yeah there is too much work left for it to work in every scenario. And those users who want to have grouped refiners can implement it through UI in the current version.

Hi, may I ask you how is this possible to do it via UI? Currently we are facing the same issue that end users gave us feedback about filters. It would be nice to have an option to group some filetypes and give them friendly display name. Thank you :)

[wobba]

@MirasMNC someone needs to invest developer time to create a filetype filter which works semantically and on the pure values.