Merge branch 'main' into main

microsoft · Nov 6, 2024 · 8f18274 · 8f18274
2 parents b621466 + 55a817f
commit 8f18274
Show file tree

Hide file tree

Showing 945 changed files with 98,599 additions and 76,855 deletions.
diff --git a/.github/AL-Go-Settings.json b/.github/AL-Go-Settings.json
@@ -1,11 +1,11 @@
 {
   "type": "PTE",
   "templateUrl": "https://github.com/microsoft/AL-Go-PTE@preview",
-  "bcContainerHelperVersion": "preview",
+  "bcContainerHelperVersion": "latest",
   "runs-on": "windows-latest",
   "cacheImageName": "",
   "UsePsSession": false,
-  "artifact": "https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/26.0.24098.0/base",
+  "artifact": "https://bcinsider-fvh2ekdjecfjd6gk.b02.azurefd.net/sandbox/26.0.26183.0/base",
   "country": "base",
   "useProjectDependencies": true,
   "repoVersion": "26.0",

diff --git a/Apps/BE/IntrastatBE/app/src/IntrastatReportManagementBE.Codeunit.al b/Apps/BE/IntrastatBE/app/src/IntrastatReportManagementBE.Codeunit.al
@@ -349,11 +349,7 @@ codeunit 11346 IntrastatReportManagementBE
     local procedure IsIntrastatExport(DataExchDefCode: Code[20]): Boolean
     var
         IntrastatReportSetup: Record "Intrastat Report Setup";
-        IntrastatReportMgt: Codeunit IntrastatReportManagement;
     begin
-        if not IntrastatReportMgt.IsFeatureEnabled() then
-            exit(false);
-
         if not IntrastatReportSetup.Get() then
             exit(false);
 

diff --git a/Apps/BE/IntrastatBE/app/src/IntrastatReportTariffNsBE.PageExt.al b/Apps/BE/IntrastatBE/app/src/IntrastatReportTariffNsBE.PageExt.al
@@ -10,22 +10,13 @@ pageextension 11350 "Intrastat Report Tariff Ns. BE" extends "Tariff Numbers"
     {
         modify("Conversion Factor")
         {
-            Visible = OldFieldsEnabled;
-            Enabled = OldFieldsEnabled;
+            Visible = false;
+            Enabled = false;
         }
         modify("Unit of Measure")
         {
-            Visible = OldFieldsEnabled;
-            Enabled = OldFieldsEnabled;
+            Visible = false;
+            Enabled = false;
         }
     }
-    trigger OnOpenPage()
-    begin
-        OldFieldsEnabled := not IntrastatReportMgt.IsFeatureEnabled();
-    end;
-
-    var
-        IntrastatReportMgt: Codeunit IntrastatReportManagement;
-        [InDataSet]
-        OldFieldsEnabled: Boolean;
 }
diff --git a/Apps/CA/HybridBCLast_CA/app/src/tables/StgDataExchDefCA.Table.al b/Apps/CA/HybridBCLast_CA/app/src/tables/StgDataExchDefCA.Table.al
@@ -1,3 +1,4 @@
+#if not CLEANSCHEMA24
 table 4046 "Stg Data Exch Def CA"
 {
     ReplicateData = false;
@@ -25,4 +26,5 @@ table 4046 "Stg Data Exch Def CA"
             Clustered = true;
         }
     }
-}
+}
+#endif
diff --git a/Apps/CH/SwissQRBill/app/src/SwissQRBillInstall.Codeunit.al b/Apps/CH/SwissQRBill/app/src/SwissQRBillInstall.Codeunit.al
@@ -56,9 +56,6 @@ codeunit 11517 "Swiss QR-Bill Install"
         with SwissQRBillSetup do
             if IsEmpty() then begin
                 "Address Type" := "Address Type"::Structured;
-#if not CLEAN23
-                "Umlaut Chars Encode Mode" := "Umlaut Chars Encode Mode"::Double;
-#endif
                 if NewDefaultLayoutCode <> '' then
                     "Default Layout" := NewDefaultLayoutCode;
                 InitDefaultJournalSetup();
@@ -176,9 +173,6 @@ codeunit 11517 "Swiss QR-Bill Install"
         if OldSwissQRBillSetup.Get() then begin
             SwissQRBillSetup.Init();
             SwissQRBillSetup."Address Type" := MapAddressType(OldSwissQRBillSetup."Address Type");
-#if not CLEAN23
-            SwissQRBillSetup."Umlaut Chars Encode Mode" := MapEncodeMode(OldSwissQRBillSetup."Umlaut Chars Encode Mode");
-#endif
             SwissQRBillSetup."Default Layout" := OldSwissQRBillSetup."Default Layout";
             SwissQRBillSetup."Last Used Reference No." := OldSwissQRBillSetup."Last Used Reference No.";
             SwissQRBillSetup."Journal Template" := OldSwissQRBillSetup."Journal Template";
@@ -231,19 +225,6 @@ codeunit 11517 "Swiss QR-Bill Install"
                 exit(SwissQRBillAddressType::Combined);
         end;
     end;
-#if not CLEAN23
-    local procedure MapEncodeMode(EncodeMode: Option Single,Double,Remove) SwissQRBillUmlautEncoding: Enum "Swiss QR-Bill Umlaut Encoding"
-    begin
-        case EncodeMode of
-            EncodeMode::Single:
-                exit(SwissQRBillUmlautEncoding::Single);
-            EncodeMode::Double:
-                exit(SwissQRBillUmlautEncoding::Double);
-            EncodeMode::Remove:
-                exit(SwissQRBillUmlautEncoding::Remove);
-        end;
-    end;
-#endif
 
     local procedure MapIBANType(IBANType: Option IBAN,"QR-IBAN") SwissQRBillIBANType: Enum "Swiss QR-Bill IBAN Type"
     begin

diff --git a/Apps/CH/SwissQRBill/app/src/purchases/SwissQRBillPurchases.Codeunit.al b/Apps/CH/SwissQRBill/app/src/purchases/SwissQRBillPurchases.Codeunit.al
@@ -551,35 +551,6 @@ codeunit 11502 "Swiss QR-Bill Purchases"
         Message(MessageResult)
     end;
 
-#if not CLEAN23
-    [EventSubscriber(ObjectType::Codeunit, Codeunit::"Purch.-Post", 'OnBeforePostVendorEntry', '', false, false)]
-    local procedure OnBeforePostVendorEntry(
-            var GenJnlLine: Record "Gen. Journal Line";
-            var PurchHeader: Record "Purchase Header";
-            var TotalPurchLine: Record "Purchase Line";
-            var TotalPurchLineLCY: Record "Purchase Line";
-            PreviewMode: Boolean;
-            CommitIsSupressed: Boolean;
-             var GenJnlPostLine: Codeunit "Gen. Jnl.-Post Line")
-    var
-        QRBillCurrencyCode: Code[10];
-        ErrText: Text;
-    begin
-        if PurchHeader."Swiss QR-Bill" and (PurchHeader."Prepayment %" = 0) and (PurchHeader."Swiss QR-Bill Amount" <> 0) then begin
-            QRBillCurrencyCode := SwissQRBillIncomingDoc.GetCurrency(PurchHeader."Swiss QR-Bill Currency");
-            if PurchHeader."Currency Code" <> QRBillCurrencyCode then begin
-                ErrText := StrSubstNo(CurrencyErr, QRBillCurrencyCode, PurchHeader."Currency Code");
-                Error(ErrText);
-            end;
-            if Abs(TotalPurchLine."Amount Including VAT") <> PurchHeader."Swiss QR-Bill Amount" then begin
-                ErrText := StrSubstNo(AmountErr, PurchHeader."Swiss QR-Bill Amount", Abs(TotalPurchLine."Amount Including VAT"));
-                Error(ErrText);
-            end;
-            VoidPurchDocQRBill(PurchHeader);
-        end;
-    end;
-#endif
-
     [EventSubscriber(ObjectType::Codeunit, Codeunit::"Purch. Post Invoice Events", 'OnPostLedgerEntryOnBeforeGenJnlPostLine', '', false, false)]
     local procedure OnPostLedgerEntryOnBeforeGenJnlPostLine(
             var GenJnlLine: Record "Gen. Journal Line";

diff --git a/Apps/CH/SwissQRBill/app/src/setup/SwissQRBillSetup.Page.al b/Apps/CH/SwissQRBill/app/src/setup/SwissQRBillSetup.Page.al
@@ -35,17 +35,6 @@ page 11514 "Swiss QR-Bill Setup"
                         ApplicationArea = All;
                         ToolTip = 'Specifies the address type used for all printed QR-bills. Recommended value is Structured.';
                     }
-#if not CLEAN23
-                    field(UmlautCharsEncodeMode; "Umlaut Chars Encode Mode")
-                    {
-                        ApplicationArea = All;
-                        ToolTip = 'Specifies the German umlaut characters encoding mode. "Single" mode: "Ä" to "A". "Double" mode: "Ä" to "Ae". The recommended value is Double.';
-                        Visible = false;
-                        ObsoleteReason = 'No need to convert umlauts, because encoding was changed to UTF-8.';
-                        ObsoleteState = Pending;
-                        ObsoleteTag = '23.0';
-                    }
-#endif
                     field(DefaultQRBillLayout; "Default Layout")
                     {
                         ApplicationArea = All;

diff --git a/Apps/CH/SwissQRBill/app/src/setup/SwissQRBillSetup.Table.al b/Apps/CH/SwissQRBill/app/src/setup/SwissQRBillSetup.Table.al
@@ -14,29 +14,30 @@ table 11512 "Swiss QR-Bill Setup"
 
     fields
     {
-        field(1; "Primary key"; Code[10]) { }
+        field(1; "Primary key"; Code[10])
+        {
+        }
+#if not CLEANSCHEMA23
         field(2; "Swiss-Cross Image"; Media)
         {
             ObsoleteState = Removed;
             ObsoleteTag = '23.0';
             ObsoleteReason = 'Use W1 codeunit 4113 "Swiss QR Code Helper"';
         }
+#endif
         field(3; "Address Type"; enum "Swiss QR-Bill Address Type")
         {
             Caption = 'Address Type';
         }
+#if not CLEANSCHEMA26
         field(6; "Umlaut Chars Encode Mode"; Enum "Swiss QR-Bill Umlaut Encoding")
         {
             Caption = 'German Umlaut Chars Encoding Mode';
             ObsoleteReason = 'No need to convert umlauts, because encoding was changed to UTF-8.';
-#if CLEAN23
             ObsoleteState = Removed;
             ObsoleteTag = '26.0';
-#else
-            ObsoleteState = Pending;
-            ObsoleteTag = '23.0';
-#endif
         }
+#endif
         field(8; "Default Layout"; Code[20])
         {
             Caption = 'Default QR-Bill Layout';

diff --git a/Apps/CH/SwissQRBill/app/src/setup/SwissQRBillSetupWizard.Page.al b/Apps/CH/SwissQRBill/app/src/setup/SwissQRBillSetupWizard.Page.al
@@ -154,18 +154,6 @@ page 11516 "Swiss QR-Bill Setup Wizard"
                         ShowMandatory = true;
                         ToolTip = 'Specifies the address type used for all printed QR-Bills. Recommended value is Structured.';
                     }
-#if not CLEAN23
-                    field(UmlautCharsEncodeMode; "Umlaut Chars Encode Mode")
-                    {
-                        ApplicationArea = All;
-                        ShowMandatory = true;
-                        ToolTip = 'Specifies the German umlaut characters encoding mode. "Single" mode: "Ä" to "A". "Double" mode: "Ä" to "Ae". Recommended value is Double.';
-                        Visible = false;
-                        ObsoleteReason = 'No need to convert umlauts, because encoding was changed to UTF-8.';
-                        ObsoleteState = Pending;
-                        ObsoleteTag = '23.0';
-                    }
-#endif
                 }
             }
             group(DefaultLayoutStep)

diff --git a/Apps/CZ/AdvancePaymentsLocalization/app/Src/Codeunits/CrossApplicationHandlerCZZ.Codeunit.al b/Apps/CZ/AdvancePaymentsLocalization/app/Src/Codeunits/CrossApplicationHandlerCZZ.Codeunit.al
@@ -25,13 +25,19 @@ codeunit 31418 "Cross Application Handler CZZ"
     [EventSubscriber(ObjectType::Table, Database::"Cash Document Line CZP", 'OnAfterCollectSuggestedApplication', '', false, false)]
     local procedure OnAfterCollectSuggestedApplicationCashDocumentLine(CashDocumentLineCZP: Record "Cash Document Line CZP"; var CrossApplicationBufferCZL: Record "Cross Application Buffer CZL")
     begin
+        if CashDocumentLineCZP."Account Type" <> CashDocumentLineCZP."Account Type"::Vendor then
+            exit;
+
         CollectSuggestedApplicationForPurchAdvLetter(
             CashDocumentLineCZP."Advance Letter No. CZZ", CashDocumentLineCZP, CrossApplicationBufferCZL);
     end;
 
     [EventSubscriber(ObjectType::Table, Database::"Payment Order Line CZB", 'OnAfterCollectSuggestedApplication', '', false, false)]
     local procedure OnAfterCollectSuggestedApplicationPaymentOrderLine(PaymentOrderLineCZB: Record "Payment Order Line CZB"; var CrossApplicationBufferCZL: Record "Cross Application Buffer CZL")
     begin
+        if PaymentOrderLineCZB.Type <> PaymentOrderLineCZB.Type::Vendor then
+            exit;
+
         CollectSuggestedApplicationForPurchAdvLetter(
             PaymentOrderLineCZB."Purch. Advance Letter No. CZZ", PaymentOrderLineCZB, CrossApplicationBufferCZL);
     end;

diff --git a/Apps/CZ/AdvancePaymentsLocalization/app/Src/Pages/AdvanceLetterTemplatesCZZ.Page.al b/Apps/CZ/AdvancePaymentsLocalization/app/Src/Pages/AdvanceLetterTemplatesCZZ.Page.al
@@ -72,50 +72,6 @@ page 31179 "Advance Letter Templates CZZ"
                 {
                     ApplicationArea = Basic, Suite;
                 }
-#if not CLEAN23
-#pragma warning disable AL0432,AS0074
-                field("Document Report ID"; '')
-                {
-                    ApplicationArea = Basic, Suite;
-                    ToolTip = 'Specifies document report ID.';
-                    Visible = false;
-                    Enabled = false;
-                    ObsoleteReason = 'Replaced by standard report selection.';
-                    ObsoleteState = Pending;
-                    ObsoleteTag = '23.0';
-                }
-                field("Document Report Caption"; '')
-                {
-                    ApplicationArea = Basic, Suite;
-                    ToolTip = 'Specifies document report caption.';
-                    Visible = false;
-                    Enabled = false;
-                    ObsoleteReason = 'Replaced by standard report selection.';
-                    ObsoleteState = Pending;
-                    ObsoleteTag = '23.0';
-                }
-                field("Invoice/Cr. Memo Report ID"; '')
-                {
-                    ApplicationArea = Basic, Suite;
-                    ToolTip = 'Specifies invoice/credit memo report ID';
-                    Visible = false;
-                    Enabled = false;
-                    ObsoleteReason = 'Replaced by standard report selection.';
-                    ObsoleteState = Pending;
-                    ObsoleteTag = '23.0';
-                }
-                field("Invoice/Cr. Memo Rep. Caption"; '')
-                {
-                    ApplicationArea = Basic, Suite;
-                    ToolTip = 'Specifies invoice/credit memo report caption.';
-                    Visible = false;
-                    Enabled = false;
-                    ObsoleteReason = 'Replaced by standard report selection.';
-                    ObsoleteState = Pending;
-                    ObsoleteTag = '23.0';
-                }
-#pragma warning restore AL0432,AS0074
-#endif
             }
         }
     }