-
Notifications
You must be signed in to change notification settings - Fork 625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Blob Storage, Azure File Share and SharePoint Online Connector Apps #23225
base: main
Are you sure you want to change the base?
Conversation
Apps/W1/File - Azure BLOB Storage Connector/app/src/BlobStorageAccount.Page.al
Outdated
Show resolved
Hide resolved
Apps/W1/File - Azure BLOB Storage Connector/app/src/BlobStorageConnectorImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
Apps/W1/File - Azure BLOB Storage Connector/app/src/BlobStorageConnectorImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
Modules/System/File Access/src/Connector/FileConnector.Interface.al
Outdated
Show resolved
Hide resolved
Modules/System/File Access/src/Connector/FileConnector.Interface.al
Outdated
Show resolved
Hide resolved
Modules/System/File Access/src/Connector/FileConnector.Interface.al
Outdated
Show resolved
Hide resolved
Some general thoughts: Additionally we might need some additional kind of top level selection before List Directories: Further more if I take a look at the current sharepoint client. I have no idea how we should map this to the current provided Sometimes a path isn't enough and we might need more information to download a file. Maybe someone else with more experience has some ideas how this access can be unified... |
Why not listing C: and D: as directory on the top level? However, I am not sure if the module should define the path separator. So all Services uses the same path structure and the implentation need to translate if needed. |
Apps/W1/File - Azure BLOB Storage Connector/app/src/BlobStorageConnectorImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool! I have a few small performance and security concerns, which I have addressed, and some minor other stuff, but nothing major. I'm excited for this.
Apps/W1/File - Azure BLOB Storage Connector/app/src/BlobStorageAccount.Table.al
Outdated
Show resolved
Hide resolved
Apps/W1/File - Azure BLOB Storage Connector/app/src/BlobStorageAccount.Table.al
Outdated
Show resolved
Hide resolved
Apps/W1/File - Azure BLOB Storage Connector/app/src/BlobStorageAccountWizard.Page.al
Outdated
Show resolved
Hide resolved
Apps/W1/File - Azure BLOB Storage Connector/app/src/BlobStorageAccountWizard.Page.al
Outdated
Show resolved
Hide resolved
Modules/System/File Access/src/Account/FileAccountImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
Let me amplify this on Twitter/X to get your initial question answered: "before I go round the whole thing, I'm interested in whether there is any interest in the module at all". Let's see what people have to say! 😊 |
I support every effort to improve file handling. |
Wonderful! Please merge this 👍🏻 |
Easily overlooked feature but a needed one. Huge development effort that should not be thrown away. |
Bravo! Love seeing more 'helper' features/functions that eventually will benefit all of us! |
@IceOnly, this PR seems to have stagnated a little (which is perfectly fine). I was just wondering if you want to push this forward at some point, or if you've changed your mind / cannot find the time? There seems to be plenty of interest for this module in the community! |
It is the time. I will try to find some free time to make the last changes. This are my open points:
|
Feel free to do it at your own pace. I didn't mean to stress you. I was just curious if you still intend to continue work. If you do, we'll just leave this PR open. No problem whatsoever. |
@JesperSchulz I need an three Object Ranges for this Apps. Which one can I used? The highest object type count is three objects. |
Apps/W1/File - SharePoint Connector/app/src/SharePointAccount.Table.al
Outdated
Show resolved
Hide resolved
Apps/W1/File - Azure File Service Connector/app/src/FileShareAccount.Table.al
Show resolved
Hide resolved
Apps/W1/File - SharePoint Connector/app/src/SharePointConnectorImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
|
||
Caption = 'SharePoint Account'; | ||
|
||
fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IceOnly could you maybe add the 2nd Authentication Type for SharePoint that was added recently .
This would require a few new Fields: Enum SharePointAuthType , a "Certificate Password Key" and a Certificate Password (Blob)
See: microsoft/BCApps#705
var | ||
SharePointFile: Record "SharePoint File"; | ||
SharePointClient: Codeunit "SharePoint Client"; | ||
TempBlob, TempBlob2 : Codeunit "Temp Blob"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apps/W1/File - SharePoint Connector/app/src/SharePointConnectorImpl.Codeunit.al
Show resolved
Hide resolved
…SAS procedure to use Secret directly
…ageConnectorImpl to use Authorization Type directly
…age across multiple files
…d CreateAccount procedures to use temporary variable names for clarity
Migration of microsoft/ALAppExtensions#23225 Now that we have made several clients Universal code ready. One of the main problems turned out to be the replacement of the file record and the file object (File.Create, File.Exists). Some of our customers now use Azure Blob Service from the System app. Others don't have a good internet and now use a local microservice with REST API, others use Azure File Shares. The problem is that every integration is different. I think many other partners will have the same problem. To simplify access I have adopted the email module and created new file accounts. With just one codeunit, a developer can now connect to various file services without having to know how they actually work. The code unit "File System" delviers everything taht is needed. An additional PR contains three connector apps: microsoft/ALAppExtensions#23225 This Apps will conenct: - Azure Blob Storage - Azure File Share - SharePoint Online All three service can be access over **one** unified interface! New provider in the future could be: - a OneDrive Provider - Third Party file services An example that shows how simple it is to use the new modules can be found here: https://github.com/IceOnly/BC_FileSystem_Example But before I go round the whole thing, I'm interested in whether there is any interest in the module at all. Here are some Screenshots: ![image](https://user-images.githubusercontent.com/3911556/236433843-11ee0b26-ee9c-4da2-8bc6-efb32675090c.png) ![image](https://user-images.githubusercontent.com/3911556/236433887-bf2bf2f2-f68e-4efa-9db5-074a6f68fad0.png) ![image](https://user-images.githubusercontent.com/3911556/236433950-e8117496-16f6-4b25-a575-42ba729ca6c3.png) ![image](https://user-images.githubusercontent.com/3911556/236434182-97fd304a-95ac-4180-9d52-9ead78899822.png) ![image](https://user-images.githubusercontent.com/3911556/236435173-a01a77bc-04de-4063-b0bb-bf18e28b2817.png) ![image](https://user-images.githubusercontent.com/3911556/236435258-56d68d50-7581-4527-bcdd-5b6e3ed53ac8.png) I have decided in favour of some restrictions. Paths must not start with a /. The only supported path separator is /. If services that require a \ are to be connected, this must be translated by the connector app. These restrictions should ensure that the file service can be exchanged without upgrading data. Assigned Workitems: Fixes #2418 Fixes [AB#559148](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/559148) --------- Co-authored-by: Stefan Sosic <[email protected]> Co-authored-by: Jesper Schulz-Wedde <[email protected]> Co-authored-by: Darrick <[email protected]>
This PR contains three new connector apps, to connect Azure Blob Storage, Azure File Share and SharePoint Online with the New File System Module in the System App.
File System Module PR:
microsoft/BCApps#663
Here are some Screenshots: