Upgrade KubernetesClient dependency #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, this commit is important for me. Have you some ideas when it could be approved ? |
|
Hey @xiaomi7732, sorry to mention you directly, but do you think you could help us with this? |
xiaomi7732
requested changes
Jan 24, 2024
| @@ -18,7 +18,7 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="KubernetesClient" Version="[10.0.16, 11.0.0)" /> | |||
| <PackageReference Include="KubernetesClient" Version="12.1.1" /> | |||
There was a problem hiding this comment.
This bumps up the lowest version supported.
If I understand correct, the version needs to be uncapped to unblock the bumping up of the dependencies. How about changing it from [10.0.16, 11.0.0) to just 10.0.16? That would be equivalent to [10.0.16, ).
Considerations:
- Backward compatibility for existing code relying on the lower version;
- Potentially breaking changes introduced in the K8sClient (major version upgrades);
If that would work for you, could you please update the PR?
There was a problem hiding this comment.
I upgraded the reference as per your request. Thank you!
tomachristian
force-pushed
the
dependencies/upgrade_kubernetes_client
branch
from
e591cce
to
38f457f
Compare
xiaomi7732
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #357.