Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typos #2892

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ For significant contributions please make sure you have completed the following
The PR will trigger build, unit tests, and functional tests automatically. Please follow [these](https://github.com/Microsoft/ApplicationInsights-dotnet/blob/develop/.github/CONTRIBUTING.md) instructions to build and test locally.

### Notes for authors:
- FxCop and other analyzers will fail the build. To see these errors yourself, compile localy using the Release configuration.
- FxCop and other analyzers will fail the build. To see these errors yourself, compile locally using the Release configuration.
2 changes: 1 addition & 1 deletion .scripts/release_GenerateReleaseMetadata.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class ReleaseInfo {
}

Function Get-GitChangeset() {
# if running localy, use git command. for VSTS, probably better to use Build.SourceVersion
# if running locally, use git command. for VSTS, probably better to use Build.SourceVersion
# Git command only works if this script executes in the repo's directory
[string]$commit = ""
try {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ protected static object LoadInstance(XElement definition, Type expectedType, obj
}
else if (instance == null)
{
CoreEventSource.Log.IncorrectInstanceAtributesConfigurationError(definition.Name.LocalName);
CoreEventSource.Log.IncorrectInstanceAttributesConfigurationError(definition.Name.LocalName);
}

if (instance != null)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ public void DiagnosticsEventThrottlingHasBeenResetForTheEvent(
Keywords = Keywords.Diagnostics,
Message = "Scheduler timer dispose failure: {0}",
Level = EventLevel.Warning)]
public void DiagnoisticsEventThrottlingSchedulerDisposeTimerFailure(
public void DiagnosticsEventThrottlingSchedulerDisposeTimerFailure(
string exception,
string appDomainName = "Incorrect")
{
Expand All @@ -112,7 +112,7 @@ public void DiagnoisticsEventThrottlingSchedulerDisposeTimerFailure(
Keywords = Keywords.Diagnostics,
Message = "A scheduler timer was created for the interval: {0}",
Level = EventLevel.Verbose)]
public void DiagnoisticsEventThrottlingSchedulerTimerWasCreated(
public void DiagnosticsEventThrottlingSchedulerTimerWasCreated(
string intervalInMilliseconds,
string appDomainName = "Incorrect")
{
Expand All @@ -124,7 +124,7 @@ public void DiagnoisticsEventThrottlingSchedulerTimerWasCreated(
Keywords = Keywords.Diagnostics,
Message = "A scheduler timer was removed",
Level = EventLevel.Verbose)]
public void DiagnoisticsEventThrottlingSchedulerTimerWasRemoved(string appDomainName = "Incorrect")
public void DiagnosticsEventThrottlingSchedulerTimerWasRemoved(string appDomainName = "Incorrect")
{
this.WriteEvent(8, this.nameProvider.Name);
}
Expand Down Expand Up @@ -237,7 +237,7 @@ public void IncorrectPropertyConfigurationError(string type, string property, st
Keywords = Keywords.UserActionable,
Message = "ApplicationInsights configuration file loading failed. Element '{0}' element does not have a Type attribute, does not specify a value and is not a valid collection type. Type initialization was skipped. Monitoring will continue.",
Level = EventLevel.Error)]
public void IncorrectInstanceAtributesConfigurationError(string definition, string appDomainName = "Incorrect")
public void IncorrectInstanceAttributesConfigurationError(string definition, string appDomainName = "Incorrect")
{
this.WriteEvent(
18,
Expand Down Expand Up @@ -604,7 +604,7 @@ public void InitializationIsSkippedForSampledItem(string appDomainName = "Incorr
public void TelemetryChannelNoInstrumentationKey(string appDomainName = "Incorrect") => this.WriteEvent(57, this.nameProvider.Name);

[Event(58, Message = "TelemetryClient.Flush was invoked.", Level = EventLevel.Verbose)]
public void TelemetlyClientFlush(string appDomainName = "Incorrect") => this.WriteEvent(58, this.nameProvider.Name);
public void TelemetryClientFlush(string appDomainName = "Incorrect") => this.WriteEvent(58, this.nameProvider.Name);

[Event(59, Message = "MetricManager.Flush was invoked.", Level = EventLevel.Verbose)]
public void MetricManagerFlush(string appDomainName = "Incorrect") => this.WriteEvent(59, this.nameProvider.Name);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ public object ScheduleToRunEveryTimeIntervalInMilliseconds(
var token = InternalCreateAndStartTimer(interval, actionToExecute);
this.timers.Add(token);

CoreEventSource.Log.DiagnoisticsEventThrottlingSchedulerTimerWasCreated(interval.ToString(CultureInfo.InvariantCulture));
CoreEventSource.Log.DiagnosticsEventThrottlingSchedulerTimerWasCreated(interval.ToString(CultureInfo.InvariantCulture));

return token;
}
Expand All @@ -67,7 +67,7 @@ public void RemoveScheduledRoutine(object token)
{
DisposeTimer(timer);

CoreEventSource.Log.DiagnoisticsEventThrottlingSchedulerTimerWasRemoved();
CoreEventSource.Log.DiagnosticsEventThrottlingSchedulerTimerWasRemoved();
}
}

Expand All @@ -85,7 +85,7 @@ private static void DisposeTimer(IDisposable timer)
}
catch (Exception exc)
{
CoreEventSource.Log.DiagnoisticsEventThrottlingSchedulerDisposeTimerFailure(exc.ToInvariantString());
CoreEventSource.Log.DiagnosticsEventThrottlingSchedulerDisposeTimerFailure(exc.ToInvariantString());
}
}

Expand Down
2 changes: 1 addition & 1 deletion BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@
{
if (exception == null)
{
exception = new Exception(Utils.PopulateRequiredStringValue(null, "message", typeof(ExceptionTelemetry).FullName));

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-BASE (ubuntu-latest, net452)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-BASE (ubuntu-latest, net481)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-BASE (ubuntu-latest, net472)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-BASE (ubuntu-latest, net462)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-NETCORE (ubuntu-latest, net481)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-NETCORE (ubuntu-latest, net480)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-NETCORE (ubuntu-latest, net472)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-NETCORE (ubuntu-latest, net462)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-BASE (ubuntu-latest, net6.0)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-BASE (ubuntu-latest, net8.0)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-REDFIELD (ubuntu-latest, netcoreapp3.1)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-REDFIELD (ubuntu-latest, net7.0)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-REDFIELD (ubuntu-latest, net6.0)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-BASE (ubuntu-latest, net7.0)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-BASE (ubuntu-latest, netcoreapp3.1)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-NETCORE (ubuntu-latest, netcoreapp3.1)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-NETCORE (ubuntu-latest, net8.0)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-NETCORE (ubuntu-latest, net6.0)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-NETCORE (ubuntu-latest, net7.0)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-BASE (ubuntu-latest, net480)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 284 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-REDFIELD (ubuntu-latest, net8.0)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
}

var telemetry = new ExceptionTelemetry(exception);
Expand Down Expand Up @@ -310,7 +310,7 @@
{
if (telemetry == null)
{
var exception = new Exception(Utils.PopulateRequiredStringValue(null, "message", typeof(ExceptionTelemetry).FullName));

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-BASE (ubuntu-latest, net452)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-BASE (ubuntu-latest, net481)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-BASE (ubuntu-latest, net472)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-BASE (ubuntu-latest, net462)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-NETCORE (ubuntu-latest, net481)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-NETCORE (ubuntu-latest, net472)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-NETCORE (ubuntu-latest, net462)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-BASE (ubuntu-latest, net6.0)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-BASE (ubuntu-latest, net8.0)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-REDFIELD (ubuntu-latest, netcoreapp3.1)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-REDFIELD (ubuntu-latest, net7.0)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-REDFIELD (ubuntu-latest, net6.0)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-BASE (ubuntu-latest, net7.0)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-BASE (ubuntu-latest, netcoreapp3.1)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-NETCORE (ubuntu-latest, netcoreapp3.1)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-NETCORE (ubuntu-latest, net8.0)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-NETCORE (ubuntu-latest, net6.0)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-NETCORE (ubuntu-latest, net7.0)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-BASE (ubuntu-latest, net480)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)

Check warning on line 313 in BASE/src/Microsoft.ApplicationInsights/TelemetryClient.cs

View workflow job for this annotation

GitHub Actions / build-test-REDFIELD (ubuntu-latest, net8.0)

Exception type System.Exception is not sufficiently specific (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2201)
telemetry = new ExceptionTelemetry(exception);
}

Expand Down Expand Up @@ -662,7 +662,7 @@
/// </remarks>
public void Flush()
{
CoreEventSource.Log.TelemetlyClientFlush();
CoreEventSource.Log.TelemetryClientFlush();

if (this.TryGetMetricManager(out MetricManager privateMetricManager))
{
Expand Down
Loading