Enable encryption at host for vms #4263
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 8a3e60f. ♻️ This comment has been updated with latest results. |
yuvalyaron
changed the title
yuvalyaron
requested review from
tamirkamara,
jonnyry and
marrobi
and removed request for
tamirkamara
yuvalyaron
commented
Jan 8, 2025
| @@ -79,7 +79,7 @@ resource "azurerm_linux_virtual_machine_scale_set" "vm_linux" { | |||
| disable_password_authentication = false | |||
| admin_password = random_password.password.result | |||
| custom_data = data.template_cloudinit_config.config.rendered | |||
| encryption_at_host_enabled = false | |||
| encryption_at_host_enabled = true | |||
There was a problem hiding this comment.
Should we enable this encryption always (similar to infrastructure_encryption_enabled), or only when enable_cmk_encryption is set to true? @marrobi @jonnyry @tamirkamara
There was a problem hiding this comment.
@SvenAelterman wdyt?
There was a problem hiding this comment.
Yes I think so, it will use the Azure managed key if not. Looks to be valuable whether CMK is used or not.
jonnyry
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added encryption at host for VMs