-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Windows image field to Admin VM template #4274
base: main
Are you sure you want to change the base?
Add Windows image field to Admin VM template #4274
Conversation
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 7e88b6e. ♻️ This comment has been updated with latest results. |
/test 9a798fa |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12815913528 (with refid (in response to this comment from @jonnyry) |
/test 9a798fa |
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/12819486131 (with refid (in response to this comment from @jonnyry) |
Is this really needed @jonnyry ? |
It is useful for us to align our Windows images to a single base image. However if there's not value to the wider user base I'm happy to close. (I realise that we could just override the image details directly in the terraform, however this aligns the mechanism with that used in the Guacamole VMs and makes it simpler to maintain.) |
Add OS image field to Admin VM template in alignment with Guacamole VMs, to allow for easier OS image customisation.