Skip to content

Commit

Permalink
[CES] Remove modern action bar survey (#2165)
Browse files Browse the repository at this point in the history
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->

Deprecate modern action bar survey

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#551374](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/551374/)
  • Loading branch information
onbuyuka authored Oct 8, 2024
1 parent 13004c0 commit 168941a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 19 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -153,12 +153,8 @@ page 9204 "User Settings"

trigger OnQueryClosePage(CloseAction: Action): Boolean
begin
if CloseAction = Action::OK then begin
if OldUserSettings."Legacy Action Bar" <> Rec."Legacy Action Bar" then
if Rec."Legacy Action Bar" then
UserSettingsImpl.ShowLegacyActionBarSurvey();
if CloseAction = Action::OK then
UserSettingsImpl.UpdateUserSettings(OldUserSettings, Rec);
end;
end;

var
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ namespace System.Environment.Configuration;
using System;
using System.Azure.Identity;
using System.Environment;
using System.Feedback;
using System.Reflection;
using System.Security.AccessControl;
using System.Security.User;
Expand Down Expand Up @@ -421,24 +420,11 @@ codeunit 9175 "User Settings Impl."
var
ApplicationUserSettings: Record "Application User Settings";
begin
ShowLegacyActionBarSurvey();
GetAppSettings(UserSecurityID, ApplicationUserSettings);
ApplicationUserSettings."Legacy Action Bar" := true;
ApplicationUserSettings.Modify();
end;

procedure ShowLegacyActionBarSurvey()
var
CustomerExperienceSurvey: Codeunit "Customer Experience Survey";
FormsProId: Text;
FormsProEligibilityId: Text;
IsEligible: Boolean;
begin
if CustomerExperienceSurvey.RegisterEventAndGetEligibility('modernactionbar_event', 'modernactionbar', FormsProId, FormsProEligibilityId, IsEligible) then
if IsEligible then
CustomerExperienceSurvey.RenderSurvey('modernactionbar', FormsProId, FormsProEligibilityId);
end;

[EventSubscriber(ObjectType::Codeunit, Codeunit::"System Action Triggers", GetAutoStartTours, '', false, false)]
local procedure CheckIfUserCalloutsAreEnabled(var IsEnabled: Boolean)
var
Expand Down

0 comments on commit 168941a

Please sign in to comment.