Improve error message and fix test

microsoft · Nov 1, 2024 · 275304b · 275304b
1 parent 5c9a53e
commit 275304b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/System Application/App/Azure Key Vault/src/AzureKeyVaultImpl.Codeunit.al b/src/System Application/App/Azure Key Vault/src/AzureKeyVaultImpl.Codeunit.al
@@ -39,7 +39,7 @@ codeunit 2202 "Azure Key Vault Impl."
         Secret := GetSecretFromClient(SecretName);
 
         if Secret = '' then
-            Error(MissingSecretErr);
+            Error(MissingSecretErr, SecretName);
     end;
 
     [NonDebuggable]
@@ -48,7 +48,7 @@ codeunit 2202 "Azure Key Vault Impl."
         Secret := GetSecretFromClient(SecretName);
 
         if Secret.IsEmpty() then
-            Error(MissingSecretErr);
+            Error(MissingSecretErr, SecretName);
     end;
 
     [NonDebuggable]

diff --git a/src/System Application/Test/Azure Key Vault/src/AzureKeyVaultTest.Codeunit.al b/src/System Application/Test/Azure Key Vault/src/AzureKeyVaultTest.Codeunit.al
@@ -23,6 +23,7 @@ codeunit 135212 "Azure Key Vault Test"
     var
         Assert: Codeunit "Library Assert";
         KeyVaultNotInitializedTxt: Label 'Azure key vault has not been set up';
+        MissingSecretErr: Label '%1 is either missing or empty', Locked = true;
 
     [Test]
     [TransactionModel(TransactionModel::AutoRollback)]
@@ -95,11 +96,12 @@ codeunit 135212 "Azure Key Vault Test"
 
         // [GIVEN] A configured Azure Key Vault
         MockAzureKeyvaultSecretProvider := MockAzureKeyvaultSecretProvider.MockAzureKeyVaultSecretProvider();
+        MockAzureKeyvaultSecretProvider.AddSecretMapping('some-secret', 'SecretFromKeyVault');
         AzureKeyVaultTestLibrary.SetAzureKeyVaultSecretProvider(MockAzureKeyvaultSecretProvider);
-        AzureKeyVaultTestLibrary.ClearSecrets();
 
         // [WHEN] The key vault is called with an unknown key
         asserterror AzureKeyVault.GetAzureKeyVaultSecret('somekeythatdoesnotexist', Secret);
+        Assert.ExpectedError(StrSubstNo(MissingSecretErr, 'somekeythatdoesnotexist'));
     end;
 
     [Test]