Skip to content

Commit

Permalink
[25.x] Fixing Purview misc mistakes in System apps (#2233)
Browse files Browse the repository at this point in the history
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
 The PR intents to fix misc typos or smaller Purview category bugs.

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#555028](https://dynamicssmb2.visualstudio.com/Dynamics%20SMB/_workitems/edit/555028)
  • Loading branch information
PredragMaricic authored Oct 21, 2024
1 parent 9a00088 commit da999e6
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,8 @@ page 7774 "Copilot Capabilities GA"
CapabilityEnabled: Boolean;
DataMovementEnabled: Boolean;
SupplementalTermsLinkTxt: Label 'https://go.microsoft.com/fwlink/?linkid=2236010', Locked = true;
CopilotFeatureDeactivatedLbl: Label 'The copilot/AI capability %1, App Id %2 has been deactivated by the UserSecurityId %3.', Locked = true;
CopilotFeatureActivatedLbl: Label 'The copilot/AI capability %1, App Id %2 has been activated by the UserSecurityId %3.', Locked = true;
CopilotFeatureDeactivatedLbl: Label 'The copilot/AI capability %1, App Id %2 has been deactivated by UserSecurityId %3.', Locked = true;
CopilotFeatureActivatedLbl: Label 'The copilot/AI capability %1, App Id %2 has been activated by UserSecurityId %3.', Locked = true;

internal procedure SetDataMovement(Value: Boolean)
begin
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ codeunit 9864 "Permission Impl."
IncludeDescriptionOption: Option "Specifies no permission","Specifies direct permission","Specifies indirect permission";
ExcludeOption: Option " ",Exclude,"Reduce to indirect";
ExcludeDescriptionOption: Option "No change to permission","Excludes any permission","Excludes any direct permission";
PermissionUpdatedLbl: Label 'The tenant %1 permission for the App Id %2, Role %3, ObjectType %4, ObjectId %5 has been updated with the value: "%6", by the UserSecurityId %7.', Locked = true;
PermissionUpdatedLbl: Label 'Tenant %1 permission for the App Id %2, Role %3, ObjectType %4, ObjectId %5 has been updated with the value: "%6", by the UserSecurityId %7.', Locked = true;
MultiplePermissionsUpdatedLbl: Label 'The tenant permissions for the App Id %1, Role %2, ObjectType %3, ObjectId %4 have been updated with the following values - Read "%5", Insert "%6", Modify "%7" and Delete "%8" by the UserSecurityId %9.', Locked = true;

procedure SelectPermissions(CurrAppId: Guid; CurrRoleID: Code[20]): Boolean
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ codeunit 1564 "Privacy Notice Approval"
procedure SetApprovalState(PrivacyNoticeId: Code[50]; UserSID: Guid; PrivacyNoticeApprovalState: Enum "Privacy Notice Approval State")
var
PrivacyNoticeApproval: Record "Privacy Notice Approval";
PrivacyNoticeApprovedLbl: Label 'Privacy Notice Approval ID %1 provided by User SID %2.', Locked = true;
PrivacyNoticeApprovedLbl: Label 'Privacy Notice Approval ID %1 provided by UserSecurityId %2.', Locked = true;
begin
if PrivacyNoticeApprovalState = "Privacy Notice Approval State"::"Not set" then begin
ResetApproval(PrivacyNoticeId, UserSID);
Expand All @@ -35,7 +35,7 @@ codeunit 1564 "Privacy Notice Approval"
procedure ResetApproval(PrivacyNoticeId: Code[50]; UserSID: Guid)
var
PrivacyNoticeApproval: Record "Privacy Notice Approval";
PrivacyNoticeResetLbl: Label 'Privacy Notice Approval ID %1 has been reset by User SID %2.', Locked = true;
PrivacyNoticeResetLbl: Label 'Privacy Notice Approval ID %1 has been reset by UserSecurityId %2.', Locked = true;
begin
PrivacyNoticeApproval.SetRange(ID, PrivacyNoticeId);
PrivacyNoticeApproval.SetRange("User SID", UserSID);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ table 3901 "Retention Policy Setup"

trigger OnInsert()
var
NewRetentionPolicyCreatedLbl: Label 'The new Retention Policy record with Table ID %1 is created by the UserSecurityId %2.', Locked = true;
NewRetentionPolicyCreatedLbl: Label 'Retention Policy record with Table ID %1 is created by the UserSecurityId %2.', Locked = true;
begin
Session.LogAuditMessage(StrSubstNo(NewRetentionPolicyCreatedLbl, Rec."Table ID", UserSecurityId()), SecurityOperationResult::Success, AuditCategory::ApplicationManagement, 3, 0);
end;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ codeunit 9175 "User Settings Impl."
UserCreatedAppNameTxt: Label '(User-created)';
DescriptionFilterTxt: Label 'Navigation menu only.';
NotEnoughPermissionsErr: Label 'You cannot open this page. Only administrators can access settings for other users.';
UserSettingsUpdatedLbl: Label 'The user settings (UserSecurityId %1) has been updated with the values: Language ID %2, Locale ID %3, Company %4, Time Zone %5, Profile ID %6 by UserSecurityId %7 ', Locked = true;
UserSettingsUpdatedLbl: Label 'User settings (UserSecurityId %1) have been updated with the values: Language ID %2, Locale ID %3, Company %4, Time Zone %5, Profile ID %6 by UserSecurityId %7 ', Locked = true;

procedure GetPageId(): Integer
var
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -700,7 +700,7 @@ codeunit 9751 "Web Service Management Impl."
var
WebService: Record "Web Service";
TenantWebService: Record "Tenant Web Service";
WebServiceCreatedLbl: Label 'The Web Service record with Object Type %1, Service Name %2 has been created by UserSecurityId %3.', Locked = true;
WebServiceCreatedLbl: Label 'Web Service record with Object Type %1, Service Name %2 has been created by UserSecurityId %3.', Locked = true;
begin
if WebServiceAggregate."All Tenants" then begin
Clear(WebService);
Expand Down

0 comments on commit da999e6

Please sign in to comment.