[Copilot] New IsCapabilityRegisteredSaaS api #1835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanSosic
approved these changes
Aug 19, 2024
|
Are there downsides to also checking for SaaS rather than cleaner separation of concern and focusing only on registration check? For example, if our registration system changes in the future (note: no plans to do so), then apps will lose the SaaS check. |
msft-sam
approved these changes
Aug 20, 2024
| /// <param name="CopilotCapability">The capability.</param> | ||
| /// <returns>True if the capability has been registered.</returns> | ||
| /// <remarks>Capabilities are tied to the module registering it. Checking for a capability will check if the enum and app id of your module exists.</remarks> | ||
| procedure IsCapabilityRegisteredSaaS(CopilotCapability: Enum "Copilot Capability"): Boolean |
There was a problem hiding this comment.
Similar to Mike's comment, the purpose of this procedure is to determine if your copilot action should be visible. The actual implementation logic isn't relevant.
Should we rename it to IsCapabilityActionVisible, or something along those lines? Then if the logic changes, we don't need to obsolete.
|
Closed as PR is not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
New api
IsCapabilityRegisteredSaaSwill check if a capability has been registered and specifically if it is onSaaSenvironment.Work Item(s)
Fixes AB#544933