Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1855 Base64 convert for secret text #1857

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

TKapitan
Copy link
Contributor

@TKapitan TKapitan commented Aug 21, 2024

Summary

Adds support for base64 for secrettexts

Work Item(s)

Fixes #1855
Fixes AB#545707

@TKapitan TKapitan requested a review from a team as a code owner August 21, 2024 16:04
@github-actions github-actions bot added AL: System Application From Fork Pull request is coming from a fork labels Aug 21, 2024
@TKapitan
Copy link
Contributor Author

@BazookaMusic @pri-kise @darjoo @JesperSchulz @WaelAbuSeada

Can you please have a look? This is quite critical for our extensions as without this we will need to revert all our changes we did in past month and return back to standard text implementation.

Let me know if you see any issues with this design, but as it returns again everything as secret text I don't see any issues as of now.

@JesperSchulz
Copy link
Contributor

@BazookaMusic @pri-kise @darjoo @JesperSchulz @WaelAbuSeada

Can you please have a look? This is quite critical for our extensions as without this we will need to revert all our changes we did in past month and return back to standard text implementation.

Let me know if you see any issues with this design, but as it returns again everything as secret text I don't see any issues as of now.

On it! I'll get this signed off today, in time for release with 25.0.

@JesperSchulz JesperSchulz self-assigned this Aug 22, 2024
@JesperSchulz JesperSchulz added the Integration GitHub request for Integration area label Aug 22, 2024
@JesperSchulz
Copy link
Contributor

Waiting to merge until we have a DevOps work item available.

@JesperSchulz JesperSchulz added the Linked Issue is linked to a Azure Boards work item label Aug 23, 2024
@github-actions github-actions bot added this to the Version 25.0 milestone Aug 23, 2024
@JesperSchulz JesperSchulz merged commit bc7d44d into microsoft:main Aug 23, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AL: System Application From Fork Pull request is coming from a fork Integration GitHub request for Integration area Linked Issue is linked to a Azure Boards work item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BC Idea]: Base64 convert support for SecretText
3 participants