Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Email] Filtering for email retrievals #2275

Merged
merged 22 commits into from
Nov 21, 2024
Merged

[Email] Filtering for email retrievals #2275

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
e356735
Add v3 interface
darjoo Oct 25, 2024
8c38f10
Fix tests
darjoo Oct 25, 2024
ffd6567
Add sanitize overload
darjoo Oct 29, 2024
4f2e84f
Add app addin
darjoo Oct 29, 2024
6ad815e
Remove var, and check for v3 before v2
darjoo Oct 29, 2024
59bda14
Replace codeunit with table for filters
darjoo Oct 29, 2024
34ecfaa
Fix obsolete reasons and consolidate dataclassification
darjoo Oct 30, 2024
a8178e5
Merge branch 'main' of https://github.com/microsoft/BCApps into priva…
darjoo Oct 30, 2024
df5c269
Merge branch 'main' of https://github.com/microsoft/BCApps into priva…
darjoo Oct 30, 2024
a328ccf
Add inherent entitlements and permissions to Email Retrieval Filters
darjoo Oct 30, 2024
3b602e3
Fix tests
darjoo Oct 31, 2024
986cc94
Update app.json for test
darjoo Oct 31, 2024
1924cff
Update app.json for test
darjoo Oct 31, 2024
8525f66
Test Email Connector v3 was looking for v2
darjoo Oct 31, 2024
4d118d0
Update test with clean tags
darjoo Oct 31, 2024
e4a1434
Merge branch 'main' of https://github.com/microsoft/BCApps into priva…
darjoo Nov 1, 2024
6e729c4
Update test
darjoo Nov 1, 2024
f4f338c
Merge branch 'main' of https://github.com/microsoft/BCApps into priva…
darjoo Nov 12, 2024
ad34b64
Fix api
darjoo Nov 12, 2024
e571695
Clean EmailMessageImpl of redundant create overloads
darjoo Nov 12, 2024
9954385
Naming convension of interface variables. Removing I prefix
darjoo Nov 13, 2024
4cf967d
Merge branch 'main' of https://github.com/microsoft/BCApps into priva…
darjoo Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/System Application/App/Email/src/Message/EmailMessageImpl.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,9 @@ codeunit 8905 "Email Message Impl."
end;

procedure Create(ToRecipients: Text; Subject: Text; Body: Text; HtmlFormatted: Boolean)
var
EmptyList: List of [Text];
begin
#pragma warning disable AA0205
Create(EmptyList, Subject, Body, HtmlFormatted, false);
Create(ToRecipients, Subject, Body, HtmlFormatted, false);
darjoo marked this conversation as resolved.
Show resolved Hide resolved
#pragma warning restore AA0205
end;

Expand Down
1 change: 0 additions & 1 deletion src/System Application/Test/Email/src/EmailTest.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,6 @@ codeunit 134685 "Email Test"
Assert.ExpectedError(EmailMessageCannotBeEditedErr);
end;


[Test]
[HandlerFunctions('EmailEditorHandler,OnEmailEditorClose')]
procedure OpenInEditorModallyDiscardAOptionTest()
Expand Down
Loading