Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Email/RetPol] Harden retention policy for Email Inbox setup. #2324

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

darjoo
Copy link
Contributor

@darjoo darjoo commented Nov 11, 2024

Summary

During upgrade and data migration, for some environments, they are running into an error that the Email Inbox is not in the allowed list of tables.

This PR fixes it by combining both upgrade functions into one, and exiting if the table is not in the list of allowed tables.

Work Item(s)

Fixes AB#556484

@darjoo darjoo requested a review from a team as a code owner November 11, 2024 13:00
@github-actions github-actions bot added this to the Version 26.0 milestone Nov 11, 2024
@darjoo darjoo merged commit 38942f4 into main Nov 11, 2024
28 checks passed
@darjoo darjoo deleted the bugs/556484 branch November 11, 2024 14:10
darjoo added a commit that referenced this pull request Nov 11, 2024
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
During upgrade and data migration, for some environments, they are
running into an error that the Email Inbox is not in the allowed list of
tables.

This PR fixes it by combining both upgrade functions into one, and
exiting if the table is not in the list of allowed tables.

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#556484](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/556484)
darjoo added a commit that referenced this pull request Nov 11, 2024
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
During upgrade and data migration, for some environments, they are
running into an error that the Email Inbox is not in the allowed list of
tables.

This PR fixes it by combining both upgrade functions into one, and
exiting if the table is not in the list of allowed tables.

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#556484](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/556484)
darjoo added a commit that referenced this pull request Nov 11, 2024
<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
During upgrade and data migration, for some environments, they are
running into an error that the Email Inbox is not in the allowed list of
tables.

This PR fixes it by combining both upgrade functions into one, and
exiting if the table is not in the list of allowed tables.

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#556484](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/556484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants