-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Email/RetPol] Harden retention policy for Email Inbox setup. #2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobyns
approved these changes
Nov 11, 2024
onbuyuka
approved these changes
Nov 11, 2024
darjoo
added a commit
that referenced
this pull request
Nov 11, 2024
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> During upgrade and data migration, for some environments, they are running into an error that the Email Inbox is not in the allowed list of tables. This PR fixes it by combining both upgrade functions into one, and exiting if the table is not in the list of allowed tables. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#556484](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/556484)
darjoo
added a commit
that referenced
this pull request
Nov 11, 2024
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> During upgrade and data migration, for some environments, they are running into an error that the Email Inbox is not in the allowed list of tables. This PR fixes it by combining both upgrade functions into one, and exiting if the table is not in the list of allowed tables. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#556484](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/556484)
darjoo
added a commit
that referenced
this pull request
Nov 11, 2024
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> During upgrade and data migration, for some environments, they are running into an error that the Email Inbox is not in the allowed list of tables. This PR fixes it by combining both upgrade functions into one, and exiting if the table is not in the list of allowed tables. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#556484](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/556484)
JesperSchulz
pushed a commit
that referenced
this pull request
Nov 12, 2024
…x setup. (#2326) This pull request backports #2324 to releases/25.1 Fixes [AB#557159](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/557159)
JesperSchulz
pushed a commit
that referenced
this pull request
Nov 12, 2024
…x setup. (#2327) This pull request backports #2324 to releases/25.0 Fixes [AB#557158](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/557158)
JesperSchulz
pushed a commit
that referenced
this pull request
Nov 12, 2024
…x setup. (#2325) This pull request backports #2324 to releases/25.x Fixes [AB#557160](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/557160)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
During upgrade and data migration, for some environments, they are running into an error that the Email Inbox is not in the allowed list of tables.
This PR fixes it by combining both upgrade functions into one, and exiting if the table is not in the list of allowed tables.
Work Item(s)
Fixes AB#556484