Add approval by default to privacy notices #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
|
@microsoft-github-policy-service agree company="Microsoft" |
1 similar comment
|
@microsoft-github-policy-service agree company="Microsoft" |
haoranpb
reviewed
Nov 19, 2024
src/System Application/App/Privacy Notice/src/PrivacyNoticeImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
|
No other comments to add. LGTM besides Haoran's comment. |
msft-sam
previously approved these changes
Nov 25, 2024
darjoo
approved these changes
Nov 26, 2024
haoranpb
approved these changes
Nov 26, 2024
edwardUL99
deleted the
private/eddylynch/549192_LearnAPIPrivacyNotice
branch
msft-sam
pushed a commit
that referenced
this pull request
Jan 3, 2025
<!-- Thank you for submitting a Pull Request. If you're new to contributing to BCApps please read our pull request guideline below * https://github.com/microsoft/BCApps/Contributing.md --> #### Summary <!-- Provide a general summary of your changes --> Quick outline of new learn api requirements form Ayrton and Jacob: 1. Implement a privacy notice which is “enabled” by default for the learn integration. 2. Implement an experience for when the privacy notice is declined by either an admin or individual user. This involves showing a UI component on the help pane notifying the user that the experience may be limited. a. If admin, the text will have a link for them to open the privacy notices page to enable it b. If user and the notice is not yet set by them or an admin, the text will have a link to open the wizard for approval c. If user and the notice is disabled by admin, the card will simply tell them to reach out to an administrator For on-prem, this isn’t supported, so no privacy notice or search box necessary. To implement 2, the current Privacy notice table does not allow us to differentiate if it is enabled by default. It simply calculates if it is approved/disabled for all users or the user decides. So I am adding a new way to allow an integration to be approved by default if not created yet or on creation. #### Work Item(s) <!-- Add the issue number here after the #. The issue needs to be open and approved. Submitting PRs with no linked issues or unapproved issues is highly discouraged. --> Fixes [AB#556896](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/556896) --------- Co-authored-by: Eddy Lynch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Quick outline of new learn api requirements form Ayrton and Jacob:
a. If admin, the text will have a link for them to open the privacy notices page to enable it
b. If user and the notice is not yet set by them or an admin, the text will have a link to open the wizard for approval
c. If user and the notice is disabled by admin, the card will simply tell them to reach out to an administrator
For on-prem, this isn’t supported, so no privacy notice or search box necessary.
To implement 2, the current Privacy notice table does not allow us to differentiate if it is enabled by default. It simply calculates if it is approved/disabled for all users or the user decides. So I am adding a new column which will identify if it is enabled by default so that the checks for approval will return approved if approved by default or admin approved. Hence, the questions on trying to add a new column to the system tables.
Work Item(s)
Fixes AB#556896