Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[releases/25.x] [Email] Filtering for email retrievals #2404

Closed

Conversation

darjoo
Copy link
Contributor

@darjoo darjoo commented Nov 26, 2024

This pull request backports #2275 to releases/25.x

Fixes AB#550315

<!-- Thank you for submitting a Pull Request. If you're new to
contributing to BCApps please read our pull request guideline below
* https://github.com/microsoft/BCApps/Contributing.md
-->
#### Summary <!-- Provide a general summary of your changes -->
- Adds a new codeunit "Email Retrieval Filters" for specifying the
filters to be used when retrieving an email.
- Update APIs to work with both v2 and v3 interfaces
- Obsolete the v2 interface as it's the same just without the filtering.
- Update tests

#### Work Item(s) <!-- Add the issue number here after the #. The issue
needs to be open and approved. Submitting PRs with no linked issues or
unapproved issues is highly discouraged. -->
Fixes
[AB#550315](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/550315)
@darjoo darjoo requested review from a team as code owners November 26, 2024 07:43
@github-actions github-actions bot modified the milestone: Version 25.2 Nov 26, 2024

using System.Email;

codeunit 134702 "Test Email Connector v3" implements "Email Connector v3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to Mock to indicate that this is a mock


procedure GetLogoAsBase64(): Text
begin

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we leave the comment why it is blank?

@darjoo
Copy link
Contributor Author

darjoo commented Nov 28, 2024

Closing this backport, will open a new one once the revert goes in as there are some other changes.

@darjoo darjoo closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants