[Bugfix] Fix correctness issue for float16xuint1 with fast dequantize #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeiWang1999
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the GPU intrinsic functions for decoding and interleaving weights in the
bitblaslibrary. The changes mainly focus on enhancing the decoding process with additional features and fixing a bug in the interleaving function.Enhancements to decoding functions:
bitblas/gpu/intrin/lop3.py: Introduced a new template functiondecode_i1b_to_f16with additional parameters for signed integers, scaling, and zero handling. This function supports different modes for zero handling (original, rescale, quantized) and includes the necessary logic for these modes.Bug fix in interleaving function:
bitblas/ops/lop3_permutate/lop3_permutate_impl.py: Corrected the bitmask and shift operation in the interleaving function to properly handle the upper bits of the input.