fix: [#9441] Multi-line SSML causes escaping issues #9444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceciliaavila
requested review from
benbrown,
natalgar,
VamsiModem,
cwhitten,
boydc2014,
a-b-r-o-w-n,
srinaath and
tdurnford
as code owners
anishprasad01
added
the
Support-P1
3 tasks
OEvgeny
previously approved these changes
May 8, 2023
OEvgeny
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the escaping issue happening when adding an SSML tag as the Speak value for a "Send a response" node.
The fixMultilineItems function in useStringArray was treating the tag as a multiline variation. We added a condition to remove the line breaks if the variation includes SSML content.
Task Item
Fixes #9441
Screenshots
These images show the escaping made before and no escaping applied after the changes.
