Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#9666] Onclick Insert property reference in a memory drop down not appearing in Bot Framework Composer 2.1.3. #9678

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

JhontSouth
Copy link
Collaborator

@JhontSouth JhontSouth commented Dec 14, 2023

Description

This PR adds the CSRF token in the headers of the fetch request of the project memory variables.

Task Item

Fixes #9666

Screenshots

The following image shows the references dropdown working after the fix.
image

@tracyboehrer
Copy link
Member

image

@tracyboehrer
Copy link
Member

Build error "The lockfile would have been modified by this install, which is explicitly forbidden."

@JhontSouth
Copy link
Collaborator Author

Build error "The lockfile would have been modified by this install, which is explicitly forbidden."

Thank you Tracy, we are reviewing it.

@@ -15,7 +15,7 @@
"serialize-javascript": "^3.1.0",
"set-value": "^3.0.2",
"terser-webpack-plugin": "^2.3.7",
"axios": "^0.21.1",
"axios": "^0.22.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs either to include updated lock files or exluding the change from the PR

@JhontSouth JhontSouth marked this pull request as draft December 18, 2023 19:57
@tracyboehrer
Copy link
Member

Summary of all failing tests
FAIL packages/client/tests/pages/language-generation/LGPage.test.tsx
● LG page all up view › should render lg page code editor

TypeError: Cannot read property 'cancel' of undefined

  102 |     // clean up pending async request
  103 |     return () => {
> 104 |       source.cancel();
      |              ^
  105 |     };
  106 |   }, [projectId]);
  107 |

  at src/pages/language-generation/code-editor.tsx:104:14
  at HTMLUnknownElement.callCallback (../../node_modules/react-dom/cjs/react-dom.development.js:188:14)
  at HTMLUnknownElement.callTheUserObjectsOperation (../../node_modules/jsdom/lib/jsdom/living/generated/EventListener.js:26:30)
  at innerInvokeEventListeners (../../node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:338:25)
  at invokeEventListeners (../../node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:274:3)
  at HTMLUnknownElementImpl._dispatch (../../node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:221:9)
  at HTMLUnknownElementImpl.dispatchEvent (../../node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:94:17)
  at HTMLUnknownElement.dispatchEvent (../../node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:231:34)
  at Object.invokeGuardedCallbackDev (../../node_modules/react-dom/cjs/react-dom.development.js:237:16)
  at invokeGuardedCallback (../../node_modules/react-dom/cjs/react-dom.development.js:292:31)
  at safelyCallDestroy (../../node_modules/react-dom/cjs/react-dom.development.js:19617:5)
  at ../../node_modules/react-dom/cjs/react-dom.development.js:20090:21
  at unstable_runWithPriority (../../node_modules/scheduler/cjs/scheduler.development.js:653:12)
  at runWithPriority$1 (../../node_modules/react-dom/cjs/react-dom.development.js:11039:10)
  at commitUnmount (../../node_modules/react-dom/cjs/react-dom.development.js:20083:15)
  at unmountHostComponents (../../node_modules/react-dom/cjs/react-dom.development.js:20464:7)
  at commitDeletion (../../node_modules/react-dom/cjs/react-dom.development.js:20500:5)
  at commitMutationEffects (../../node_modules/react-dom/cjs/react-dom.development.js:22782:11)
  at HTMLUnknownElement.callCallback (../../node_modules/react-dom/cjs/react-dom.development.js:188:14)
  at HTMLUnknownElement.callTheUserObjectsOperation (../../node_modules/jsdom/lib/jsdom/living/generated/EventListener.js:26:30)
  at innerInvokeEventListeners (../../node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:338:25)
  at invokeEventListeners (../../node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:274:3)
  at HTMLUnknownElementImpl._dispatch (../../node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:221:9)
  at HTMLUnknownElementImpl.dispatchEvent (../../node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:94:17)
  at HTMLUnknownElement.dispatchEvent (../../node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:231:34)
  at Object.invokeGuardedCallbackDev (../../node_modules/react-dom/cjs/react-dom.development.js:237:16)
  at invokeGuardedCallback (../../node_modules/react-dom/cjs/react-dom.development.js:292:31)
  at commitRootImpl (../../node_modules/react-dom/cjs/react-dom.development.js:22509:9)
  at unstable_runWithPriority (../../node_modules/scheduler/cjs/scheduler.development.js:653:12)
  at runWithPriority$1 (../../node_modules/react-dom/cjs/react-dom.development.js:11039:10)
  at commitRoot (../../node_modules/react-dom/cjs/react-dom.development.js:22381:3)
  at finishSyncRender (../../node_modules/react-dom/cjs/react-dom.development.js:21807:3)
  at performSyncWorkOnRoot (../../node_modules/react-dom/cjs/react-dom.development.js:21793:7)
  at scheduleUpdateOnFiber (../../node_modules/react-dom/cjs/react-dom.development.js:21188:7)
  at updateContainer (../../node_modules/react-dom/cjs/react-dom.development.js:24373:3)
  at legacyRenderSubtreeIntoContainer (../../node_modules/react-dom/cjs/react-dom.development.js:2[477](https://github.com/microsoft/BotFramework-Composer/actions/runs/7264840533/job/19795205920?pr=9678#step:9:478)4:5)
  at ../../node_modules/react-dom/cjs/react-dom.development.js:2[488](https://github.com/microsoft/BotFramework-Composer/actions/runs/7264840533/job/19795205920?pr=9678#step:9:489)4:7
  at unbatchedUpdates (../../node_modules/react-dom/cjs/react-dom.development.js:21903:12)
  at Object.unmountComponentAtNode (../../node_modules/react-dom/cjs/react-dom.development.js:24883:5)
  at ../../node_modules/@testing-library/react/dist/pure.js:144:23
  at batchedUpdates$1 (../../node_modules/react-dom/cjs/react-dom.development.js:21856:12)
  at act (../../node_modules/react-dom/cjs/react-dom-test-utils.development.js:929:14)
  at cleanupAtContainer (../../node_modules/@testing-library/react/dist/pure.js:143:26)
      at Set.forEach (<anonymous>)
  at cleanup (../../node_modules/@testing-library/react/dist/pure.js:137:21)
  at Object.<anonymous> (../../node_modules/@testing-library/react/dist/index.js:33:25)

@coveralls
Copy link

Coverage Status

coverage: 54.482% (-0.008%) from 54.49%
when pulling 2fa312f on southworks/fix/enable-references-dropdown
into 1a93f21 on main.

@JhontSouth JhontSouth marked this pull request as ready for review January 3, 2024 14:27
@JhontSouth
Copy link
Collaborator Author

@tracyboehrer , @OEvgeny
We reverted the axios updates and kept the fetch request, but now we're using the CSRF token in the request headers.
The PR is ready for review now.

@tracyboehrer tracyboehrer merged commit 707cfdd into main Jan 16, 2024
8 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/enable-references-dropdown branch January 16, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onclick Insert property reference in a memory drop down not appearing in Bot Framework Composer 2.1.3.
4 participants