Skip to content

Commit

Permalink
Add comments for future improvements
Browse files Browse the repository at this point in the history
Signed-off-by: lemccomb <[email protected]>
  • Loading branch information
lemccomb authored Nov 20, 2024
1 parent 52f9d3f commit a54c911
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/dotnet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,9 @@ jobs:
dotnet publish --configuration Debug --self-contained true --output published/debug --property:FileVersion=$VERSION CoseSignTool/CoseSignTool.csproj
dotnet publish --configuration Release --self-contained true --output published/release --property:FileVersion=$VERSION CoseSignTool/CoseSignTool.csproj
# Self-contained is needed. Must use .csproj instead of .sln.
# Ideally we should also verify in the Build and Test job, but that will require pre-caulculating the version number and either
# Running build and test separately because we can't pass the version number to dotnet test, or
# Setting the version number dynamically in the csproj files, using <FileVersion>$(VersionBin)</FileVersion>
shell: bash

# List the contents of the published directory to make sure all the artifacts are there.
Expand Down

0 comments on commit a54c911

Please sign in to comment.