Disable ninja by default #5194
Merged
Disable ninja by default #5194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadams
approved these changes
Feb 26, 2024
ShellyNR
pushed a commit
to ShellyNR/DeepSpeed
that referenced
this pull request
Mar 11, 2024
microsoft#5192 reports an issue with the latest DeepSpeed release (0.13.3) related to pre-compilation and the recently re-enabled `ninja` support in microsoft#5088. Reverting to disabling `ninja` by default, but users can still enable it with `DS_ENABLE_NINJA=1` until we can further debug to understand the problem.
rraminen
pushed a commit
to ROCm/DeepSpeed
that referenced
this pull request
May 9, 2024
microsoft#5192 reports an issue with the latest DeepSpeed release (0.13.3) related to pre-compilation and the recently re-enabled `ninja` support in microsoft#5088. Reverting to disabling `ninja` by default, but users can still enable it with `DS_ENABLE_NINJA=1` until we can further debug to understand the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5192 reports an issue with the latest DeepSpeed release (0.13.3) related to pre-compilation and the recently re-enabled
ninjasupport in #5088. Reverting to disablingninjaby default, but users can still enable it withDS_ENABLE_NINJA=1until we can further debug to understand the problem.