Fix compile wrapper #5455
Merged
Fix compile wrapper #5455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compile wrapper will inherit from user module base class and copy it's __dict__ Change-Id: Ia21acf29da1f34593187c2119482d49059c4608a
tohtana
approved these changes
May 8, 2024
|
Thank you for an awesome solution to the issues! |
|
Hi Nadav,
Sorry for the delay, I just approved the PR.
I like your solution to the issues. Thank you for the contribution!
Best,
Masahiro
…________________________________
From: Nadav Elyahu ***@***.***>
Sent: Wednesday, May 8, 2024 12:36 AM
To: microsoft/DeepSpeed ***@***.***>
Cc: Masahiro Tanaka ***@***.***>; Mention ***@***.***>
Subject: Re: [microsoft/DeepSpeed] Fix compile wrapper (PR #5455)
@tohtana<https://github.com/tohtana> @tjruwase<https://github.com/tjruwase> can you review this PR? this solves a major bug in current compile wrapper solution
—
Reply to this email directly, view it on GitHub<#5455 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATMLYCCJTBQT3TTIZ3OF37DZBHIYLAVCNFSM6AAAAABGVWT4LWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJZHEZTSMRYGY>.
You are receiving this because you were mentioned.
|
umchand
pushed a commit
to umchand/DeepSpeed
that referenced
this pull request
May 20, 2024
compile wrapper will inherit from user module class and copy it's __dict__ This should resolve most issues in microsoft#5383 except potential extra user forward hooks. @tohtana @loadams Co-authored-by: Logan Adams <[email protected]> Co-authored-by: Olatunji Ruwase <[email protected]> Co-authored-by: Masahiro Tanaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compile wrapper will inherit from user module class and copy it's dict
This should resolve most issues in #5383 except potential extra user forward hooks.
@tohtana @loadams