Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable torch compile on _allgather_params #6769

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Enable torch compile on _allgather_params #6769

merged 3 commits into from
Nov 21, 2024

Conversation

deepcharm
Copy link
Contributor

  • Previosuly ZerO3 was crashing when trying to compile _allgather_params
  • Disabling grad solves the issue

@deepcharm
Enable torch compile on _allgather_params
7e7ec27 
* Previosuly ZerO3 was crashing when trying to compile _allgather_params
* Disabling grad solves the issue
@deepcharm deepcharm requested a review from tjruwase as a code owner November 20, 2024 16:40
@tjruwase tjruwase added this pull request to the merge queue Nov 21, 2024
Merged via the queue into microsoft:master with commit b5709cc Nov 21, 2024
12 checks passed
@deepcharm deepcharm deleted the enable-torch-compile-on_allgather_params branch November 25, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjruwase tjruwase tjruwase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepcharm @tjruwase