Fix: ensure deepspeed.initialize
can only be called once.
#6848
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Fixes: #6772 #6771 #6770 by forbidding repeated initialization.
_deepspeed_initialized
to track initialization state.RuntimeError
ifinitialize
is called more than once.This is a draft issue as we have not included the unit test for this PR
@tjruwase
We currently added a global variable to enforce that
deepspeed.initialize
can only be called once in one single interpreter.However, this seems to have interfered with existing tests that might intentionally call this API multiple times.
A solution might be to record
id
of the models and optimizers that have been used, to enforce the semantics only for individual models and optimizers, but that might get trickier and complicated, thus we'd like to hear some feedback on how this should be implemented before proceeding.