Skip to content

Commit

Permalink
Format
Browse files Browse the repository at this point in the history
  • Loading branch information
typescript-bot committed Aug 8, 2024
1 parent 5685dda commit 446e702
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 5 deletions.
11 changes: 7 additions & 4 deletions packages/mergebot/src/compute-pr-actions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -245,10 +245,13 @@ function extendPrInfo(info: PrInfo): ExtendedPrInfo {
function getReviewColumn(): ColumnName {
// Get the project column for review with least access
// E.g. let people review, but fall back to the DT maintainers based on the access rights above
return blessed ? "Waiting for Code Reviews (Blessed)"
: approverKind !== "maintainer" ? "Waiting for Code Reviews"
: blessable ? "Needs Maintainer Review"
: "Needs Maintainer Action";
return blessed
? "Waiting for Code Reviews (Blessed)"
: approverKind !== "maintainer"
? "Waiting for Code Reviews"
: blessable
? "Needs Maintainer Review"
: "Needs Maintainer Action";
}
}

Expand Down
5 changes: 4 additions & 1 deletion packages/mergebot/src/pr-info.ts
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,10 @@ function getLastCommentishActivityDate(prInfo: PR_repository_pullRequest) {
return max([...latestIssueCommentDate, ...latestReviewCommentDate]);
}

function getLastMaintainerBlessing(after: Date, pr: PR_repository_pullRequest): { date: Date | undefined; column: BlessedColumnName } | undefined {
function getLastMaintainerBlessing(
after: Date,
pr: PR_repository_pullRequest,
): { date: Date | undefined; column: BlessedColumnName } | undefined {
const card = pr.projectItems.nodes?.find((card) => card?.project.number === projectBoardNumber);
const columnName =
card?.fieldValueByName?.__typename === "ProjectV2ItemFieldSingleSelectValue" && card.fieldValueByName.name;
Expand Down

0 comments on commit 446e702

Please sign in to comment.