Error on versioned directories when parent npmignores are missing sub…

…dir (#971)
microsoft · Mar 4, 2024 · 465dbce · 465dbce
1 parent b4d4432
commit 465dbce
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/.changeset/hot-dogs-leave.md b/.changeset/hot-dogs-leave.md
@@ -0,0 +1,5 @@
+---
+"@definitelytyped/dtslint": patch
+---
+
+Error on versioned directories when parent npmignores are missing subdir
diff --git a/packages/dtslint/src/index.ts b/packages/dtslint/src/index.ts
@@ -355,6 +355,17 @@ function checkExpectedFiles(dirPath: string, isLatest: boolean): { errors: strin
           expectedNpmIgnore.push(`/${subdir.name}/`);
         }
       }
+    } else {
+      const thisDir = `/${basename(dirPath)}/`;
+      const parentNpmIgnorePath = joinPaths(dirname(dirPath), ".npmignore");
+      if (!fs.existsSync(parentNpmIgnorePath)) {
+        errors.push(`${dirPath}: Missing parent '.npmignore'`);
+      } else {
+        const parentNpmIgnore = fs.readFileSync(parentNpmIgnorePath, "utf-8").trim().split(/\r?\n/);
+        if (!parentNpmIgnore.includes(thisDir)) {
+          errors.push(`${dirPath}: Parent package '.npmignore' should contain ${thisDir}`);
+        }
+      }
     }
 
     const expectedNpmIgnoreAsString = expectedNpmIgnore.join("\n");