Shift around absolute checks

microsoft · Feb 21, 2024 · a80dc03 · a80dc03
1 parent 87de946
commit a80dc03
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/definitions-parser/src/get-affected-packages.ts b/packages/definitions-parser/src/get-affected-packages.ts
@@ -1,7 +1,8 @@
 import { assertDefined, execAndThrowErrors, mapDefined, normalizeSlashes, withoutStart } from "@definitelytyped/utils";
 import { AllPackages, PackageId, formatTypingVersion, getDependencyFromFile } from "./packages";
-import { resolve } from "path";
+import { isAbsolute, resolve } from "path";
 import { satisfies } from "semver";
+import assert from "assert";
 export interface PreparePackagesResult {
   readonly packageNames: Set<string>;
   readonly dependents: Set<string>;
@@ -77,7 +78,8 @@ export async function getAffectedPackagesWorker(
   dependentOutputs: string[],
   definitelyTypedPath: string,
 ): Promise<PreparePackagesResult> {
-  const dt = resolve(definitelyTypedPath);
+  assert(isAbsolute(definitelyTypedPath), "definitelyTypedPath should be absolute");
+  const dt = definitelyTypedPath;
   const changedDirs = mapDefined(changedOutput.split("\n"), getDirectoryName(dt));
   const dependentDirs = mapDefined(dependentOutputs.join("\n").split("\n"), getDirectoryName(dt));
   const packageNames = new Set([

diff --git a/packages/dtslint-runner/src/main.ts b/packages/dtslint-runner/src/main.ts
@@ -9,6 +9,7 @@ import fs from "fs";
 import { RunDTSLintOptions } from "./types";
 import { prepareAllPackages } from "./prepareAllPackages";
 import { prepareAffectedPackages } from "./prepareAffectedPackages";
+import { resolve } from "path";
 
 export async function runDTSLint({
   definitelyTypedAcquisition,
@@ -36,6 +37,7 @@ export async function runDTSLint({
   } else {
     definitelyTypedPath = definitelyTypedAcquisition.path;
   }
+  definitelyTypedPath = resolve(definitelyTypedPath);
 
   if (!fs.existsSync(definitelyTypedPath)) {
     throw new Error(`Path '${definitelyTypedPath}' does not exist.`);