Don’t crash when implementation package fails to extract (#948)

* Wrap createPackage in try/catch * Add changeset * Fix package lock
microsoft · Feb 12, 2024 · aa26880 · aa26880
1 parent 4b738ac
commit aa26880
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/.changeset/little-timers-reflect.md b/.changeset/little-timers-reflect.md
@@ -0,0 +1,5 @@
+---
+"@definitelytyped/dtslint": patch
+---
+
+Don’t crash when implementation package fails to extract
diff --git a/packages/dtslint/src/checks.ts b/packages/dtslint/src/checks.ts
@@ -275,7 +275,14 @@ export async function checkNpmVersionAndGetMatchingImplementationPackage(
             `that does not conflict with an existing npm package.`,
         );
       } else {
-        implementationPackage = await attw.createPackageFromTarballUrl(tarballUrl);
+        try {
+          implementationPackage = await attw.createPackageFromTarballUrl(tarballUrl);
+        } catch (err: any) {
+          (warnings ??= []).push(
+            `Failed to extract implementation package from ${tarballUrl}. This is likely a problem with @arethetypeswrong/core ` +
+            `or the tarball data itself. @arethetypeswrong/cli will not run. Error:\n${err.stack ?? err.message}`
+          );
+        }
       }
     }
   } else if (packageJson.nonNpm === "conflict") {