Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ts-expect-error for specific version ranges #1021

Merged
merged 8 commits into from
Jun 26, 2024

Conversation

jakebailey
Copy link
Member

This enables writing:

// @ts-expect-error >=5.5

Which means "only expect an error in 5.5 and above".

Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

packages/eslint-plugin/src/rules/expect.ts Outdated Show resolved Hide resolved
@jakebailey
Copy link
Member Author

My test isn't yet right; having a hard time getting an error that appears in 5.5 but not 5.4.

@jakebailey jakebailey merged commit 8100279 into microsoft:main Jun 26, 2024
7 checks passed
@jakebailey jakebailey deleted the conditional-expect-error branch June 26, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants