Add fetchTypesPackageVersionInfo() tests #464
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm slammed right now, but I'll take a look at your PRs when I have my Definitely Typed rotation week. In the meantime, the top of my wishlist is adding eslint to CI runs so that we can start migrating off of tslint, especially our custom rules. But that requires a lot of testing to make sure performance isn't worse and results are the same. |
|
@sandersn Understood. Thank you! |
jablko
force-pushed
the
patch-52
branch
2 times, most recently
from
5413ffe
to
8da2aa1
Compare
jablko
force-pushed
the
patch-52
branch
2 times, most recently
from
2e37952
to
6859143
Compare
jablko
force-pushed
the
patch-52
branch
6 times, most recently
from
e3595e6
to
d1eb3a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a couple of tests for fetchTypesPackageVersionInfo(), to exercise #447.
canPublishargument and instead return both the published and incipient versions. The caller can decide which they want.