Detect package names added/removed from attw.json as changed #944
Conversation
|
The way that we install things means that this will cause new failures; we use a filtered install so pnpm is not going to know that it needs to install those packages too and so they'll definitely fail tests. A potential way we can try and do this is to update https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/scripts/pnpm-install.sh to detect that case and tack on a few more filters. That or we move |
| const versionPath = isLatest ? dirPath : joinPaths(dirPath, `ts${hi}`); | ||
| if (lows.length > 1) { | ||
| console.log("testing from", low, "to", hi, "in", versionPath); | ||
| if (npmChecks !== "only") { |
There was a problem hiding this comment.
Maybe this is a nit, but if this were written as an early return, I think it may be clearer / less diff-y?
if (npmChecks === "only") {
return;
}There was a problem hiding this comment.
There’s stuff after this block, though
There was a problem hiding this comment.
Ah, crap. The GitHub diff ended perfectly right after the block and I really thought the function had ended 😄
|
I tested it locally on DefinitelyTyped/DefinitelyTyped#68558 and it worked. |
For DefinitelyTyped/DefinitelyTyped#68558 (and others in the future)