Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch expect to using settings for versionsToTest #970

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

jakebailey
Copy link
Member

settings are global, cascading/merging options that get passed down to rules. When I moved expect to eslint, I didn't really know how they worked, so opted to use Options, which were hacky and required overrides.

But now we're wanting to check multiple tsconfigs, so we need somewhere to store that information. We can't add another option because dtslint's options will totally override any user provided options. But if we use settings, they will merge together, so dtslint can set the TS versions, and the user can specify something like extraTsconfigs: ["./tsconfig.dom.json"].

packages/eslint-plugin/src/rules/expect.ts Outdated Show resolved Hide resolved
@jakebailey jakebailey merged commit 5dae397 into microsoft:main Mar 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants