Switch expect to using settings for versionsToTest #970
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
settings
are global, cascading/merging options that get passed down to rules. When I movedexpect
to eslint, I didn't really know how they worked, so opted to useOptions
, which were hacky and required overrides.But now we're wanting to check multiple tsconfigs, so we need somewhere to store that information. We can't add another option because
dtslint
's options will totally override any user provided options. But if we usesettings
, they will merge together, so dtslint can set the TS versions, and the user can specify something likeextraTsconfigs: ["./tsconfig.dom.json"]
.