Adding support for Dhalion to fetch metrics from multiple metrics pro… #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashvina
requested changes
Dec 21, 2018
| import java.util.Map; | ||
| import java.util.Set; | ||
|
|
||
| public class CompositeMetricsProvider implements MetricsProvider { |
There was a problem hiding this comment.
This class needs some a javadoc to help users know the behavior of this implementation
|
|
||
| @VisibleForTesting | ||
| protected void instantiateMetricsProviders() throws ClassNotFoundException { | ||
| Injector injector = Guice.createInjector(new AbstractModule() { |
There was a problem hiding this comment.
Creating an injector here does not seem correct. This injector can only be used for instantiating metrics providers that need sysconfig. This may not be sufficient. If at all there needs to be a way to pass the injector in the constructor and use it.
| } | ||
| } | ||
|
|
||
| protected void addMetricsProvider(MetricsProvider provider) { |
There was a problem hiding this comment.
Is this protected for testing?
| metricsProvider.initialize(); | ||
| Set<String> metricTypes = metricsProvider.getMetricTypes(); | ||
| if (metricTypes != null) { | ||
| for (String metricType : metricsProvider.getMetricTypes()) { |
There was a problem hiding this comment.
Reuse the metric type set above?
Suggested change
| for (String metricType : metricsProvider.getMetricTypes()) { | |
| for (String metricType : metricTypes) { |
| Set<String> metricTypes = metricsProvider.getMetricTypes(); | ||
| if (metricTypes != null) { | ||
| for (String metricType : metricsProvider.getMetricTypes()) { | ||
| metricsProviderMap.put(metricType, metricsProvider); |
There was a problem hiding this comment.
Should an exception be thrown if more than one metrics provider supports a metric type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…viders.