Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing dummy map file name to be consistent with PQFlashIndex and del… #588

Merged
merged 3 commits into from
Oct 6, 2024
Merged

Fixing dummy map file name to be consistent with PQFlashIndex and del… #588

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
253ed7f
Fixing dummy map file name to be consistent with PQFlashIndex and del…
gopal-msr Oct 3, 2024
209955a
Fixed code formatting
gopal-msr Oct 6, 2024
55b9f3c
Upgrading upload-artifact to v4
gopal-msr Oct 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/disk_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1188,7 +1188,7 @@ int build_disk_index(const char *dataFilePath, const char *indexFilePath, const
std::string mem_univ_label_file = mem_index_path + "_universal_label.txt";
std::string disk_univ_label_file = disk_index_path + "_universal_label.txt";
std::string disk_labels_int_map_file = disk_index_path + "_labels_map.txt";
std::string dummy_remap_file = disk_index_path + "_dummy_remap.txt"; // remap will be used if we break-up points of
std::string dummy_remap_file = disk_index_path + "_dummy_map.txt"; // remap will be used if we break-up points of
// high label-density to create copies

std::string sample_base_prefix = index_prefix_path + "_sample";
Expand Down Expand Up @@ -1274,7 +1274,6 @@ int build_disk_index(const char *dataFilePath, const char *indexFilePath, const
augmented_labels_file = index_prefix_path + "_augmented_labels.txt";
if (filter_threshold != 0)
{
dummy_remap_file = index_prefix_path + "_dummy_remap.txt";
breakup_dense_points<T>(data_file_to_use, labels_file_to_use, filter_threshold, augmented_data_file,
augmented_labels_file,
dummy_remap_file); // RKNOTE: This has large memory footprint,
Expand Down Expand Up @@ -1365,6 +1364,8 @@ int build_disk_index(const char *dataFilePath, const char *indexFilePath, const
if (created_temp_file_for_processed_data)
std::remove(prepped_base.c_str());
std::remove(mem_index_path.c_str());
std::remove((mem_index_path + ".data").c_str());
std::remove((mem_index_path + ".tags").c_str());
if (use_disk_pq)
std::remove(disk_pq_compressed_vectors_path.c_str());

Expand Down
Loading