Update push-test.yml #591
Update push-test.yml #591
Conversation
When the upload-artifact action was updated to v4, the behavior of it changes such that you cannot create a unified "artifact" by having it add files to an existing artifact name. Instead, they all require a unique artifact name to be uploaded. This should fix the current workflow build errors.
|
The artifact woes are more extensive than I thought - I will address them all in a single PR, not just one I made through the github file editor 😆 |
|
Thanks Dax, I didn't realize how complicated this change was :) |
|
Yeah, this is why I didn't upgrade it before, I think the only problem we'll have is the python wheel part since that'll be across like N different artifacts, but it's not insurmountable - just a lot of places to adjust. I'll try to get this together today :) |
…starts in upload-artifact@v4
…inux8 (why the heck is this docker image still shipping with an old gpg key anyway)
|
This is still failing on one of the dynamic tests but it's getting surprising exit codes and isn't really in scope for this PR. Someone more competent in the windows-diskann-dynamic workflow space should probably check to see why sometimes we get random exit codes of 127 and such though. Seems like we have a bug somewhere? |
|
[laugh] Dax Pryce reacted to your message:
…________________________________
From: gopalrs ***@***.***>
Sent: Wednesday, October 16, 2024 7:36:59 AM
To: microsoft/DiskANN ***@***.***>
Cc: Dax Pryce ***@***.***>; Author ***@***.***>
Subject: Re: [microsoft/DiskANN] Update push-test.yml (PR #591)
Thanks Dax, I didn't realize how complicated this change was :)
—
Reply to this email directly, view it on GitHub<#591 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAG3SU7I6B5Q57GIBV5FGJLZ3YJRXAVCNFSM6AAAAABQABU3ZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMJVHE3DIMZTGU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
I will look into the other test failures, Dax. Thanks for fixing the upload issues. |
* Update push-test.yml When the upload-artifact action was updated to v4, the behavior of it changes such that you cannot create a unified "artifact" by having it add files to an existing artifact name. Instead, they all require a unique artifact name to be uploaded. This should fix the current workflow build errors. * Trying to fix the workflow to handle the name collision problem that starts in upload-artifact@v4 * Trying to get the cibuildwheel tool to work with the changes to AlmaLinux8 (why the heck is this docker image still shipping with an old gpg key anyway) * Dynamic and Dynamic Labels were both trying to write to the artifact
When the upload-artifact action was updated to v4, the behavior of it changes such that you cannot create a unified "artifact" by having it add files to an existing artifact name. Instead, they all require a unique artifact name to be uploaded.
This should fix the current workflow build errors.