Removed usage of the FeatureMonotone function.

microsoft · Feb 20, 2020 · c4a9ce8 · c4a9ce8
1 parent 2f15206
commit c4a9ce8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/treelearner/monotone_constraints.hpp b/src/treelearner/monotone_constraints.hpp
@@ -115,8 +115,9 @@ class LeafConstraints {
     int parent_idx = learner_state.tree->node_parent(node_idx);
     if (parent_idx != -1) {
       int inner_feature = learner_state.tree->split_feature_inner(parent_idx);
+      int feature = learner_state.tree->split_feature(parent_idx);
       int8_t monotone_type =
-          learner_state.train_data_->FeatureMonotone(inner_feature);
+          learner_state.config_->monotone_constraints[feature];
       bool is_right_split =
           learner_state.tree->right_child(parent_idx) == node_idx;
       bool split_contains_new_information = true;

diff --git a/src/treelearner/serial_tree_learner.cpp b/src/treelearner/serial_tree_learner.cpp
@@ -533,7 +533,7 @@ int32_t SerialTreeLearner::ForceSplits(Tree* tree, const Json& forced_split_json
     // we want to know if the feature has to be monotone
     bool feature_is_monotone = false;
     if (!config_->monotone_constraints.empty()) {
-        feature_is_monotone = config_->monotone_constraints[inner_feature_index] != 0;
+        feature_is_monotone = config_->monotone_constraints[current_split_info.feature] != 0;
     }
     auto threshold_double = train_data_->RealThreshold(
             inner_feature_index, current_split_info.threshold);