Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Increase timeout value for QEMU builds #4385

Merged
merged 1 commit into from
Jun 16, 2021
Merged

[ci] Increase timeout value for QEMU builds #4385

merged 1 commit into from
Jun 16, 2021

Conversation

StrikerRUS
Copy link
Collaborator

Seem that previous bump (#4326) is not enough.

##[error]The job running on agent Hosted Agent ran longer than the maximum time of 150 minutes.
https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=10344&view=logs&j=c2f9361f-3c13-57db-3206-cee89820d5e3

Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow 3 hours 😬

Ok I still think that won't be a problem at the current pace of development in this repo. If it becomes a problem maybe we should consider moving some of these to optional jobs triggered by comments in the future.

But for now, approved!

@StrikerRUS
Copy link
Collaborator Author

StrikerRUS commented Jun 16, 2021

wow 3 hours 😬

Agree... 🙁

Typical pattern is simply set max allowed value

timeoutInMinutes: 360
https://github.com/search?l=YAML&p=1&q=qemu+timeoutInMinutes&type=Code

But unfortunately, long runs are related to QEMU itself (it is common practice to set timeout=360 for QEMU builds) because in those jobs all tests contribute to slowness.
#3948 (comment)

If it becomes a problem maybe we should consider moving some of these to optional jobs triggered by comments in the future.

... or just skip some tests there.

@StrikerRUS StrikerRUS merged commit 6afd9bf into master Jun 16, 2021
@StrikerRUS StrikerRUS deleted the qemu branch June 16, 2021 21:32
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants