-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] use flag '--allow-releaseinfo-change' in some 'apt-get update' calls #4524
Conversation
Doesn't seem like this worked 😬 I'm going to try just rebuilding #4522, maybe it was fixed upstrean. |
That did not work, sadly. https://github.com/microsoft/LightGBM/pull/4522/checks?check_run_id=3334336822 Investigating some other options locally right now. |
Following another suggestion from https://www.mail-archive.com/[email protected]/msg772749.html worked for me locally (in a container using the
Just pushed 890feea, which I hope will resolve this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for fast fix!
I think we can add this flag to other apt-get update
calls.
Sure! I didn't do that here because I think it needs a bit of investigation. I'm not sure what version of |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
On PRs I opened within the last hour (#4522, #4523), the
r-package (ubuntu-latest, R-devel, GCC ASAN/UBSAN) (pull_request)
job is failing.https://github.com/microsoft/LightGBM/pull/4523/checks?check_run_id=3332073359
After some research, I think this could be fixed by preferring
apt update
toapt-get update
. A similar error was reported a few hours ago in https://www.mail-archive.com/[email protected]/msg772749.html, and responses in that thread suggest that runningapt update
in place ofapt-get update
can fix it (e.g. https://www.mail-archive.com/[email protected]/msg772763.html).As far as I can tell from that thread, this is happening because of this combination of factors:
apt-get update
does not install new dependencies of upgradeable software (https://linuxhint.com/diff_apt_vs_aptget/)Opening this PR to replace calls to
apt-get update
withapt update
in R jobs usingrhub/
container images.Notes for Reviewers
It's possible similar changes will need to be made for other jobs in the future, and maybe even that we should completely prefer
apt
toapt-get
, but that requires more research and I think it's outside of the scope of this PR.