-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Install matplotlib and graphviz when creating conda env #5509
Conversation
ha oh! Didn't know you were also working on this. I just opened #5510 with an alternative approach that I hope might be a bit more future-proof than re-ordering when we install things. Let's see which one works 😬 |
@jameslamb Thanks. I think both solutions are okay as long as they work. I can close this one if you feel that #5510 is a better solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do feel like #5510 might be a more permanent solution to this...but I'm approving this since it's building successfully for now. That way, you can merge this to unblock CI and work on other things (since it's late for me here in the U.S. and I'm about to go to sleep).
I'll probably continue experimenting with #5510 more this week.
Thanks for working on this!
Thanks. But it seems that Windows bdist build fails now with Azure DevOps. Not sure if it is related to this change. Will restart the tests to check. |
I just pushed a change over in #5510 that I think could be a permanent fix. Learned today that it's possible to include build tags in the environment description for conda, so for example you can do conda install 'python=3.7.12[build=*cpython]` |
Close with a replacing solution in #5510. |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
This is trying to solve #5507.