Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: [dask] [python-package] clean up failed futures if network setup fails (fixes #5390) #5597

Closed
wants to merge 5 commits into from
Closed

WIP: [dask] [python-package] clean up failed futures if network setup fails (fixes #5390) #5597

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
debd3b2
[ci] remove constraints on dask and scipy in CI (fixes #5390)
jameslamb Nov 21, 2022
b9cfbfd
add scipy
jameslamb Nov 21, 2022
c5b3fec
set small timeout on restart
jameslamb Nov 22, 2022
e558602
set timeout on client.restart()
jameslamb Nov 22, 2022
0b7c5c0
Merge branch 'master' into remove-dask-constraint
jameslamb Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/python_package_test/test_dask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1656,7 +1656,7 @@ def test_machines_should_be_used_if_provided(task, cluster):
dask_model.fit(dX, dy, group=dg)

# The above error leaves a worker waiting
client.restart()
client.restart(timeout=5, wait_for_workers=True)

# an informative error should be raised if "machines" has duplicates
one_open_port = lgb.dask._find_n_open_ports(1)
Expand Down