-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix updates in random forest model using GOSS data sample strategy #6017
Conversation
1) Value of data_sample_strategy was not written out in Config::SaveMembersToString() 2) GOSSStrategy->Bagging may modify value of bag_data_cnt_ during training, which may mean tmp_grad_ and tmp_hess_ need resizing in RF::TrainOneIter
This is required by LightGBMNet
@jameslamb Are we ready to merge this now please? |
I've just merged In the future, you can reduce the time it takes to get changes reviewed and merged here by doing the following in pull requests:
Thanks as always for your help with LightGBM! |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
1) Value of data_sample_strategy was not written out in Config::SaveMembersToString()2) GOSSStrategy->Bagging may modify value of bag_data_cnt_ during training, which may mean tmp_grad_ and tmp_hess_ need resizing in RF::TrainOneIter. Without this change, an exception is thrown during training at line 138 of rf.hpp.