Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues #137 and #138 #139

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Fixed issues #137 and #138 #139

merged 3 commits into from
Feb 24, 2023

Conversation

bjoernf73
Copy link
Contributor

@bjoernf73 bjoernf73 commented Jan 9, 2023

The following fixes issues
#137
#138


This change is Reviewable

@bjoernf73
Copy link
Contributor Author

@microsoft-github-policy-service agree

@bjoernf73 bjoernf73 changed the title Fixed errors #137 and #138 Fixed issues #137 and #138 Jan 9, 2023
@ykuijs
Copy link
Member

ykuijs commented Feb 14, 2023

This solution causes a Catch-22 issue:
It depends on the Get-PnPContext cmdlet, which means we first have to connect to SharePoint using Connect-PnPOnline before that cmdlet works. However, we need the SPO Admin URL in order to run that cmdlet and that is exactly what we are trying to find in this code.

So I think we have to go with the solution I proposed in the issue in M365DSC. I will create a new PR, which will also fix the other issue.

@NikCharlebois NikCharlebois merged commit 1d077ab into microsoft:Dev Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants